We should follow GitHub Ruby Styleguide.
Strings section says:
Prefer double-quoted strings. Interpolation and escaped characters will always work without a delimiter change, and ' is a lot more common than " in string literals.
Version: unspecified
Severity: normal
Whiteboard: gci2013 https://www.mediawiki.org/wiki/Google_Code-In#Candidate_tasks
URL: https://www.google-melange.com/gci/task/view/google/gci2013/5896231096156160
List of repositories that contain Ruby code is here: https://github.com/wikimedia/mediawiki-selenium
The first step is to clone all repositories (Gerrit link) and replace all double quotes with single quotes in all .rb and .feature files.
Change 97756 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97761 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Check syntax of all Ruby files in a repository:
find . -name "*.rb" -exec ruby -wc {} \;
Change 97762 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97765 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97769 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97773 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97781 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97788 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97842 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97849 had a related patch set uploaded by Mayankmadan:
Prefer double-quoted strings in Ruby code
Change 97842 merged by Tobias Gritschacher:
Prefer double-quoted strings in Ruby code
I'm still not sure what to prefer - single or double quotes. Now, with double quotes everywhere, I get tons of warnings in RubyMine (so their default setting prefers single quotes it seems) telling "Double quoted string with no interpolation and special symbols".
You can always revert the commit if you prefer single quotes. :) I thought following github ruby convention is a step forward.
Change 97788 merged by jenkins-bot:
[Browser tests] Prefer double-quoted strings in Ruby code
Change 102198 had a related patch set uploaded by Zfilipin:
Replacing single quotes with double quotes
Change 102204 had a related patch set uploaded by Zfilipin:
Replacing single quotes with double quotes
Change 102207 had a related patch set uploaded by Zfilipin:
Replacing single quotes with double quotes
Change 102209 had a related patch set uploaded by Zfilipin:
Replacing single quotes with double quotes
Change 102211 had a related patch set uploaded by Zfilipin:
WIP Replacing single quotes with double quotes
Change 102213 had a related patch set uploaded by Zfilipin:
Replacing single quotes with double quotes
Change 102215 had a related patch set uploaded by Zfilipin:
[browser test] Replacing single quotes with double quotes
Change 102215 abandoned by Cmcmahon:
[browser test] Replacing single quotes with double quotes
Reason:
abandoned in favor of https://gerrit.wikimedia.org/r/#/c/102710/
Change 105400 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105401 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105402 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105403 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105404 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105407 had a related patch set uploaded by Zfilipin:
[browser test] Updated Ruby and RubyGems
Change 105409 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox
Change 105410 had a related patch set uploaded by Zfilipin:
Updated Ruby, RubyGems and Firefox