Page MenuHomePhabricator

In Allpages wrong parameters passed in call to showChunk
Closed, ResolvedPublic

Description

Author: roddy

Description:
In the call to showChunk from showTopLevel four parameters are passed but showChunk only takes
three - and extra false is included which means that the $including flag is not passed correctly
and when Special:Allpages is included and there are only a small number of pages it shows the
navigation form when it shouldn't.

Suggested fix - remove the false in the call to showChunk below

If there are only two or less sections, don't even display them.
Instead, display the first section directly.
if( count( $lines ) <= 2 ) {

		$this->showChunk( $namespace, '', false, $including );
		return;

}


Version: 1.6.x
Severity: normal

Details

Reference
bz4014

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:58 PM
bzimport set Reference to bz4014.
bzimport added a subscriber: Unknown Object (MLST).

It looks ok to me...

		$this->showChunk( $namespace, '', false, $including );

Oh wait, the code sample above is *wrong* instead of the suggested fix. Blaaaaahhh...