Page MenuHomePhabricator

firstHeading class
Closed, InvalidPublic

Description

Author: brian

Description:
<h1 class="firstHeading">(pagetitle)</h1>

Why not call the class "pageTitle" to reflect what the class is used for? This class
does not appear to be used anywhere else.


Version: unspecified
Severity: enhancement

Details

Reference
bz4217

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:59 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz4217.
bzimport added a subscriber: Unknown Object (MLST).

No reason to change it; it is the first heading.

brian wrote:

It's true that it's the first heading, but it would be nice to know a bit more
when looking at the CSS; also, it might not always be the first heading (we might
make the first heading the site title and this the second heading).

brian wrote:

You resolved the bug without giving an explanation.

robchur wrote:

(In reply to comment #2)

(we might make the first heading the site title and this the second heading).

...in which case we'd update the CSS and any affected output to reflect it.

brian wrote:

This seems unnecessarily complicated.

robchur wrote:

No, *this* is an unnecessary waste of *our* time. We've done things how we've
done them for a reason. A lot of the bug reports you've been filing aren't
actual bug reports, but comments on our SGML or some other trivial detail that
isn't broken. Obviously, I don't want to put you off filing genuine bug reports,
making genuine comments and trying to be helpful, but persistently commenting on
every little quirk MediaWiki has is going to sap up your energies, as it is.
Please restrict what you create to being proper bug reports or feature requests.

brian wrote:

It's only trivial if you think it's trivial. Isn't this why we have a severity
of "trivial" and a priority of "lowest"?

robchur wrote:

(In reply to comment #8)

It's only trivial if you think it's trivial. Isn't this why we have a severity
of "trivial" and a priority of "lowest"?

Those are for things that are actually broken and need fixing, but aren't vital.