Page MenuHomePhabricator

Flow: archive search in page header triggers error
Closed, ResolvedPublic


screenshot of error

If I have {{archives}} or {{Talk header}} in the page header area, Flow gives this error (screenshot):

The error message received was: Exception Caught: ID searchbox already defined

Version: unspecified
Severity: normal
See Also:


Screenshot_from_2014-02-03_13:38:45.png (1×1 px, 182 KB)



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:07 AM
bzimport set Reference to bz60785.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 14474
screenshot 2

After reading the error in the preview (screenshot 1), I removed the {{archives}} box, and hit save. That resulted in this: (screenshot 2)

So I re-edited the header to remove {{Talk header}}. Once I hit save for that, it was still displaying the same error, until I did shift-F5 (hard-refresh).


Screenshot_from_2014-02-03_13:39:49.png (1×1 px, 219 KB)

Parsoid is being strict about disallowing the duplicate element IDs in HTML (bug 60816).

But these templates should not be causing invalid HTML output by specifying id=searchbox twice. Somewhere besides {{archives |search=yes}} there must be another id=searchbox; I tried adding the template wikitext to [[wp:Wikipedia_talk:Flow/Developer_test_page]] but couldn't reproduce it. Assuming that's the problem these templates should use a unique ID, maybe we can alert their authors. Any special styling or behavior they're getting should be due to classes, not an ID.

For grins, you could try to add the problematic templates in VisualEditor.

  • Bug 60816 has been marked as a duplicate of this bug. ***

Change 111224 had a related patch set uploaded by EBernhardson:
Don't error out on duplicate id's

I think the "id=searchbox" is coming from and there are frequently more than one searchbox per page so that does need to be solved.

aha! bug 11777 (Multiple inputboxes make page invalid due to repetitive similar id) I don't know if that bug needs to be poked, with this fresh example? It's been silent since Sept 2012.

Change 111224 merged by jenkins-bot:
Don't error out on duplicate id's