Page MenuHomePhabricator

Flow: regression: "Show changes" compare-revisions gets diff error
Closed, ResolvedPublic

Description

Find any edited post on ee-flow or beta-wiki, click its mini-pencil icon and choose Show changes, every time I get an error:

Error
Diff operation can only be done for two revisions belonging to the same post."

I just made and edited (as Selenium user) on Talk:Sandbox the "New post, test edit" post under "New topic, test edit"

http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic_newRevision=05101971fe9de08a3c1bfa163e68c4ac&topic_oldRevision=0510195fc1a1e08a3c1bfa163e68c4ac&workflow=0510195fc195e08a3c1bfa163e68c4ac&action=compare-revisions

The fix for bug 56196 changed query string parameter names from [] to _. If I change the _ back to [], I see the diff fine:

http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic[newRevision]=05101971fe9de08a3c1bfa163e68c4ac&topic[oldRevision]=0510195fc1a1e08a3c1bfa163e68c4ac&workflow=0510195fc195e08a3c1bfa163e68c4ac&action=compare-revisions


Version: master
Severity: major
URL: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow&topic_newRevision=051019b8127934b9401d02163e39327f&topic_oldRevision=0509c8092f50eefec58902163e39327f&workflow=0509c8092f3ceefec58902163e39327f&action=compare-revisions

Details

Reference
bz60947

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:01 AM
bzimport set Reference to bz60947.
bzimport added a subscriber: Unknown Object (MLST).

Change 111823 had a related patch set uploaded by EBernhardson:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/111823

Change 111823 merged by jenkins-bot:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/111823

  • Bug 61098 has been marked as a duplicate of this bug. ***

Change 112729 had a related patch set uploaded by EBernhardson:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/112729

Change 112729 merged by jenkins-bot:
Properly parse out underscored parameters

https://gerrit.wikimedia.org/r/112729

(gerrit 112729 was a backport to 1.23wmf13)