UserMailer: replyto problem: use the string for mailing, not the (MailAddress) object
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	Dec 22 2005, 12:42 AM

Description

recently, the MailAddress object was introduced for the "to" and "from" string in UserMailer. "replyto" strings
need to be handled in a similar way (patch follows).

Version: 1.6.x
Severity: normal

Details

Reference: bz4347

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:01 PM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz4347.

• bzimport added a subscriber: Unknown Object (MLST).

Wikinaut created this task.Dec 22 2005, 12:42 AM

Created attachment 1227
patch; needs review

attachment CVS-HEAD.diff ignored as obsolete

Created attachment 1230
revised patch (CVS HEAD) -- please review and apply

I forgot the patch for the variable $wgNoReplyAddress --> MailAddress(
$wgNoReplyAddress ), which is used for composing the REPLY-TO when a)
pageeditor has no mailaddress, e.g. anonymous editors. or b) pageeditor has
opted-out to reveal their address or c) the feature is fully switched off by
Sysop.

Paging the devlopers to commit this after review.

Attached:

CVS-HEAD.diff1 KBDownload

Brion, hello.

Please can you fix that problem now ? You apparently forgot to patch these three
lines when you recently introduced MailAddress() objects in UserMailer.php.

As you know, I cannot commit to the CVS.

need-review, patch

I corrected some typo and committed it as r19746.

UserMailer: replyto problem: use the string for mailing, not the (MailAddress) objectClosed, ResolvedPublicActions

Description

Details

Event Timeline

UserMailer: replyto problem: use the string for mailing, not the (MailAddress) object
Closed, ResolvedPublic
Actions