Page MenuHomePhabricator

Flow: browser test checks for post "1 second ago" but the test can display "3 seconds ago"
Closed, ResolvedPublic

Description

flow_anon's "Add new Flow topic" wait_until 20 seconds to check

page.text.include? "1 second ago" or page.text.include? "just now"

But computers can be slow; https://saucelabs.com/jobs/79f3dc0639f74c09a2f9640edd0d971d failed because the new topic showed "3 seconds ago". Besides, the same test page can be simultaneously hit by other browsers, so some topic appearing recently doesn't test successful addition of this topic.

The test should instead look for a topic titlebar (css: '.flow-topic-container .flow-titlebar' ) with a h2 matching the random number it just inserted, and within the titlebar it should accept '.flow-datestamp .flow-ago' containing "seconds ago" as well as "1 second ago" or "just now".


Version: master
Severity: minor

Details

Reference
bz61582

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:08 AM
bzimport set Reference to bz61582.
bzimport added a subscriber: Unknown Object (MLST).

Change 120189 had a related patch set uploaded by Spage:
Handle "N seconds ago" instead of dying

https://gerrit.wikimedia.org/r/120189

Change 120189 merged by jenkins-bot:
Handle "N seconds ago" instead of dying

https://gerrit.wikimedia.org/r/120189

All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

No reply to comment 3 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:40 AM