Page MenuHomePhabricator

Cannot edit specific sections on semi protected articles
Closed, ResolvedPublic

Description

Author: woohookitty

Description:
Apparently, on semi protected articles, "edit this page" is available but you
cannot edit by section. In other words, the "edit" button at the beginning of
each section does not exist. Please fix. Thanks.


Version: unspecified
Severity: normal
OS: Windows XP
Platform: PC

Details

Reference
bz4385

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:59 PM
bzimport set Reference to bz4385.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Is this a cosmetic issue, i.e. the section editing link is hidden, or is it a
functional issue, i.e. index.php?title=foo&action=edit&section=n doesn't work?

woohookitty wrote:

It's cosmetic. I tried the direct links and they work. Still. Needs to be fixed.

  1. Provide URLs to particular pages
  2. Describe what type of accounts you are testing with (sysop, old, new, anon)
  3. Does ?action=purge clear it up?

woohookitty wrote:

It's basically all semi protected articles.
http://en.wikipedia.org/wiki/George_W._Bush, http://en.wikipedia.org/wiki/Jesus,
http://en.wikipedia.org/wiki/Chuck_Norr are just a few. As far as who I tired it
with. Well, it's not going to apply to anons and new users (and yes I tested it)
because they can't edit semi protected pages. I used purge and yes it cleared it
up. Thanks.

Looks like it's all protected pages, not just semi-protected ones. Semi-protected pages probably change more often, making it more visible. Fix is probably to change ParserCache.php to add $title->userCanEdit() or such into the hash key, so it saves different versions for those who can and those who can't edit.

Done on HEAD, should work now. Do a purge on any already-affected pages.