Page MenuHomePhabricator

Transclusion of {{fullurl:{{FULLPAGENAME}}}} on Commons gives broken links elsewhere
Closed, ResolvedPublic

Description

Author: wiki.bugzilla

Description:
There are several pages on Commons that are used as templates
for user specific license boxes, compare (permalink to current version):
http://commons.wikimedia.org/w/index.php?title=User:Raymond_de/licence&oldid=1171429

The variables {{fullurl:{{FULLPAGENAME}}}} are used correctly there
and work well while viewing images directly on Commons.

But if you look at a transcluded image elsewhere, e.g.
http://en.wikipedia.org/wiki/Image:Duisburg-Ruhrort_Panorama_1.jpg
you'll find (below the license) a broken link at the template section
"Onlinemedium". This link is in the form of
http://commons.wikimedia.orghttp://commons.wikimedia.org/wiki/Image:Duisburg-Ruhrort_Panorama_1.jpg
(fullurl is doubled).


Version: 1.6.x
Severity: normal
URL: http://en.wikipedia.org/wiki/Image:Duisburg-Ruhrort_Panorama_1.jpg

Details

Reference
bz4571

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:03 PM
bzimport set Reference to bz4571.
bzimport added a subscriber: Unknown Object (MLST).

What do they 'work' to do? URLs aren't template names...

Simpler test case:
http://test.leuksman.com/index.php?action=render&title=4571

This is probably because the hack for URL expansion in render mode is misplaced in
Title::getLocalUrl() instead of higher up where it belongs. Something is then applying a
duplicate $wgServer on the front.

Fixed on HEAD; Title.php revision 1.258.

Just a quick-fix hack; avoid duplicating the prefix in getFullUrl() if the test for
render in getLocalUrl() passes and already prepends it.

  • Bug 4544 has been marked as a duplicate of this bug. ***