Page MenuHomePhabricator

Uninitialized local variables
Closed, ResolvedPublic

Description

Author: Michael.Keppler

Description:
The following local variables are not initialized anywhere. Please note that
this is not an unfiltered list of potentially undefined variables, but those are
the 3 remaining items from a list of 71 potential items reported by PHPeclipse,
which I checked for includes, loops, extract() or other specialities, so I'm
certainly sure, they are not initialized.

Skin.php, doGetUserStyles(), $action, line 321 (missing global?)
SpecialNewPages.php, feedItemDesc(), $text, line 101 (completely unused?)
SquidUpdate.php, purge(), $s, line 147 (copy paste error from below, where $s is
defined?)


Version: 1.6.x
Severity: normal

Details

Reference
bz4940

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:04 PM
bzimport set Reference to bz4940.
bzimport added a subscriber: Unknown Object (MLST).

Added @todo for Skin.php $action.
Fixed SquidUpdate.php $s , that caused socket to always be blocking.

I havent found the other issues in the code.

robchur wrote:

Fixed the issue in Skin.php in SVN trunk, r14489. Can't find the reference to
$text in SpecialNewpages.php where cited, so I think we can assume this was
fixed another time.