Page MenuHomePhabricator

Flow front-end: preview of header edit is extra-narrow
Closed, ResolvedPublic

Description

  1. Click the pencil to edit an existing Flow board header.
  2. Click Preview.

Result: the previewed text has an additional 200px right margin that isn't in the actual header.

The div for the preview has style="flow-board-header flow-preview", and flow-board-header has 200px right margin, but we're already in the flow-board-header. So either don't nest, or don't style.


Version: master
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67629

Details

Reference
bz67496

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz67496.
bzimport added a subscriber: Unknown Object (MLST).
Spage created this task.Jul 3 2014, 9:39 PM

I mean flow-board-header has 200px padding-right (in modules/new/styles/layout.less).

Created attachment 15840
Flow header preview, note the padding-right that narrows it

Attached:

Change 160165 had a related patch set uploaded by EBernhardson:
Fix preview of header edit is extra-narrow

https://gerrit.wikimedia.org/r/160165

Change 160165 merged by jenkins-bot:
Fix preview of header edit is extra-narrow

https://gerrit.wikimedia.org/r/160165

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:34 AM