Page MenuHomePhabricator

view Echo notifications get fatal in Flow Notifications/Formatter.php
Closed, ResolvedPublic

Description

Benny visited test.wikipedia.org for the first time in months, clicking Echo notification overlay or visiting Special:Notifications caused a fatal.

It's not happening for spage. Nothing in fatals.log for other servers or users.

[2014-07-30 23:23:19] Fatal error: Call to a member function getAlphadecimal() on a non-object at /usr/local/apache/common-local/php-1.24wmf15/extensions/Flow/includes/Notifications/Formatter.php on line 67
Server: mw1017
Method: GET
URL: http://test.wikipedia.org/wiki/Special:Notifications
Cookie: XXX
Backtrace:
#0 /usr/local/apache/common-local/php-1.24wmf15/extensions/Flow/includes/Notifications/Formatter.php(67): Flow\NotificationFormatter::getPostLinkAnchor()
#1 /usr/local/apache/common-local/php-1.24wmf15/extensions/Flow/includes/Notifications/Formatter.php(31): Flow\NotificationFormatter->getPostLinkAnchor(Object(EchoEvent), Object(User))
#2 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/formatters/BasicFormatter.php(647): Flow\NotificationFormatter->processParam(Object(EchoEvent), 'post-permalink', Object(Message), Object(User))
#3 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/formatters/BasicFormatter.php(361): EchoBasicFormatter->processParams(Array, Object(EchoEvent), Object(Message), Object(User))
#4 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/formatters/BasicFormatter.php(262): EchoBasicFormatter->formatFragment(Array, Object(EchoEvent), Object(User))
#5 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/formatters/BasicFormatter.php(222): EchoBasicFormatter->formatNotificationTitle(Object(EchoEvent), Object(User))
#6 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/controller/NotificationController.php(338): EchoBasicFormatter->format(Object(EchoEvent), Object(User), 'web')
#7 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/api/ApiEchoNotifications.php(145): EchoNotificationController::formatNotification(Object(EchoEvent), Object(User), 'html')
#8 /usr/local/apache/common-local/php-1.24wmf15/extensions/Echo/special/SpecialNotifications.php(41): ApiEchoNotifications::getNotifications(Object(User), 'html', 21, NULL)
#9 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPage.php(382): SpecialNotifications->execute(NULL)
#10 /usr/local/apache/common-local/php-1.24wmf15/includes/specialpage/SpecialPageFactory.php(516): SpecialPage->run(NULL)
#11 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#12 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(603): MediaWiki->performRequest()
#13 /usr/local/apache/common-local/php-1.24wmf15/includes/MediaWiki.php(452): MediaWiki->main()
#14 /usr/local/apache/common-local/php-1.24wmf15/index.php(46): MediaWiki->run()
#15 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#16 {main}


Version: master
Severity: normal

Details

Reference
bz68885

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz68885.
bzimport added a subscriber: Unknown Object (MLST).

Change 150739 had a related patch set uploaded by EBernhardson:
Prevent fatal error when formatting old notifications

https://gerrit.wikimedia.org/r/150739

Change 150739 merged by jenkins-bot:
Prevent fatal error when formatting old notifications

https://gerrit.wikimedia.org/r/150739

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM