Page MenuHomePhabricator

Clicking Recommendations flyout multiple times produces excess recommendations
Closed, ResolvedPublic

Description

Author: swalling

Description:
Excess pagination

Steps to reproduce:

  • Visit any page while logged in on Beta Labs
  • Click the "Recommendations" toolbar link while logged in
  • If it does not appear immediately, which is common on a slow connection or because Labs is slow, then keep clicking

Error: When the flytout finally appears, it should produce far more than three pages worth of recommendations, in accordance with your repeated clicks. (See screenshot.)

Expected behavior: only three pages should appear no matter what.


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-08-18_at_11.29.10_PM.png (1×2 px, 1 MB)

Details

Reference
bz69719

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:41 AM
bzimport set Reference to bz69719.

Nice catch. This is the kind of bug software engineers never catch because we know how it's supposed to work. ;)

Change 155431 had a related patch set uploaded by Robmoen:
Prevent multiple api requests from firing

https://gerrit.wikimedia.org/r/155431

Change 155431 merged by jenkins-bot:
Prevent multiple api requests from firing

https://gerrit.wikimedia.org/r/155431