Page MenuHomePhabricator

Top-right links appear at top-left in IE 7.0.5331.0
Closed, DeclinedPublic

Description

The latest internal release of IE, version 7.0.5331.0, has an issue with MediaWiki 1.5.7 where the
links user, user talk, etc. that normally appear in the top right are in the top left. This is both
ugly and extrememly annoying, because if you try to click on them, you'll click on the logo instead
and go to the home page. This release of IE is not public, but I'll try to attach a screenshot and
will be happy to evaluate any potential solution for developers on my own MediaWiki server. The
problem reproduces on my wiki (a slightly modified 1.5.7 at literateprograms.org) but not on
Wikipedia.


Version: 1.8.x
Severity: normal
OS: Windows XP
Platform: PC
Whiteboard: aklapper-moreinfo

Details

Reference
bz5207

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:09 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz5207.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 1446
A screenshot of the issue described

Attached:

IE7LinksOnLeft.PNG (199×1 px, 49 KB)

Note that this may be an IE7 issue rather than a MediaWiki issue. I'll pass it on to the IE
team if you think it's an IE7 issue.

No problems with 7.0.5296.0. A regression could be either due to bugs in IE,
bugs in our workarounds for IE bugs exposed by new changes, etc.

Is this available in the latest Vista beta build, or is it really internal-only?
I've had huge troubles getting Vista working in VMWare (if it installs, usually
there's no networking...)

Note: we've done more extensive changes to the IE bug workarounds in MediaWiki 1.6,
fixing lots of problems primarily with right-to-left languages. This might change
behavior for LTR as well. You can test this at our own sites (eg,
http://en.wikipedia.org and friends) or install a local copy from CVS.

The issue doesn't repro on English Wikipedia. I'm guessing some change in 1.6 fixed it. I'll
try some selective merging and see if I can confirm this.

I did the following and this issue went away.

  1. Replace these 2 lines in MediaWiki 1.5.7's skins/MonoBook.php:

    <!--[if gte IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php

$this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->

<!--[if lt IE 7]><script type="<?php $this->text('jsmimetype') ?>" src="<?php $this->text

('stylepath') ?>/common/IEFixes.js"></script>

with these 2 lines from the current build:

<!--[if IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php

$this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->

<!--[if IE 7]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php

$this->text('stylename') ?>/IE70Fixes.css?1";</style><![endif]-->

  1. Copy in the file skins/monobook/IE70Fixes.css from the current build.

At least for MonoBook, this made the links appear in the correct place again.

pasixxxx wrote:

Currently the latest IE7 version is 7.0.5700.6IS (=Release Candidate 1).

In the Wikipedia's current version of Mediawiki, IE70Fixes.css has a line that sets the height of content
(div that has id="content") to 1%. It fixes some problems with links I'm not sure...

Is this fix any longer valid?

jimmy.collins wrote:

I don't have problems with 7.0.5600.16384 (in Vista RC1).

janunson wrote:

I have this problem in 1.8 with 7.0.5730.11
script output has the IE70Fixes.css commented out (maybe that's the way it's supposed to work(?)- like
this:

<link title="Creative Commons" type="application/rdf+xml" href="/wiki/index.php?
title=Category:Standards&amp;action=creativecommons" rel="meta" />
<link rel="copyright" href="http://www.gnu.org/copyleft/fdl.html" />

		<title>Category:Standards - HelpNET</title>
		<style type="text/css" media="screen,projection">/*<![CDATA[*/

@import "/wiki/skins/monobook/main.css?42"; /*]]>*/</style>

		<link rel="stylesheet" type="text/css" media="print"

href="/wiki/skins/common/commonPrint.css?42" />

		<link rel="stylesheet" type="text/css" media="handheld"

href="/wiki/skins/monobook/handheld.css?42" />

		<!--[if lt IE 5.5000]><style type="text/css">@import "/wiki/skins/monobook/IE50Fixes.css?

42";</style><![endif]-->

		<!--[if IE 5.5000]><style type="text/css">@import "/wiki/skins/monobook/IE55Fixes.css?

42";</style><![endif]-->

		<!--[if IE 6]><style type="text/css">@import "/wiki/skins/monobook/IE60Fixes.css?

42";</style><![endif]-->

		<!--[if IE 7]><style type="text/css">@import "/wiki/skins/monobook/IE70Fixes.css?

42";</style><![endif]-->

		<!--[if lt IE 7]><script type="text/javascript" src="/wiki/skins/common/IEFixes.js?

42"></script>

		<meta http-equiv="imagetoolbar" content="no" /><![endif]-->
		
		<script type= "text/javascript">/*<![CDATA[*/

It is supposed to work that way. IE detects that it's a conditional comment and renders the content if the condition matches, while it's still a comment for the other browsers. See http://msdn.microsoft.com/en-us/library/ms537512.aspx

Derrick / Jon: Is this still an issue, or is this long gone and this report can be closed as obsolete (RESOLVED WORKSFORME)?

I no longer have access to the stated version of IE and it may have never been released at all.

Sure. Thanks for the feedback!