Page MenuHomePhabricator

searchNs does not necessarily returns True when searchable
Closed, InvalidPublic

Description

This makes site_tests fail.

FAIL: testSearch (site_tests.TestSiteObject)

Test the site.search() method

Traceback (most recent call last):

File "site_tests.py", line 780, in testSearch
  self.assertTrue(all(hit.namespace() in search_ns for hit in se))

AssertionError: False is not true

On wikisource:

https://en.wikisource.org//w/api.php?action=query&format=json&meta=userinfo&maxlag=5&uiprop=blockinfo|hasmsg|options&format=jsonfm

{

"query": {
    "userinfo": {
        "id": 257091,
        "name": "Mpaa",
        "options": {
            ...
            "searchNs0": "",
            "searchNs1": false,
            "searchNs2": false,
            "searchNs3": false,
            "searchNs4": false,
            "searchNs5": false,
            "searchNs6": false,
            "searchNs7": false,
            "searchNs8": false,
            "searchNs9": false,
            "searchNs10": false,
            "searchNs11": false,
            "searchNs12": false,
            "searchNs13": false,
            "searchNs14": false,
            "searchNs15": false,
            "searchNs100": false,
            "searchNs101": false,
            "searchNs102": "",
            "searchNs103": false,
            "searchNs104": false,
            "searchNs105": false,
            "searchNs106": "",
            "searchNs107": false,
            "searchNs114": "",
            "searchNs115": false,
            "searchNs828": false,
            "searchNs829": false,
            ...
        }
    }
}

}


Version: core-(2.0)
Severity: normal

Details

Reference
bz70809

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
bzimport set Reference to bz70809.
bzimport added a subscriber: Unknown Object (????).

"searchNs0": "" is actually not searchable.
So not an error.

Maybe the test should be skipped in such condition?