Page MenuHomePhabricator

Flow: {{Foo}} in topic title is treated as a template in topic placeholder
Closed, ResolvedPublic

Description

Create a topic with "Title has {{foo}} in it" as the title.
In the same session, the placeholder text for a top-level topic reply becomes

Reply to "Title has  in it"

Now reload the board, or follow the Permalink to the topic. The placeholder for a top-level topic reply becomes

Reply to "Title has [[:Template:Foo]] in it"

It seems the progressive enhancement on the client is evaluating {{Foo}} as a handlebars template, while the server is evaluating it as wikitext. Both are incorrect, titles are plain text and should appear that way in the placeholder.

When you view the topic permalink, its HTML page <title> seems to have correct escaping of the topic title.

To reproduce both bugs, view http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow so you see "This topic has ..." and "Another topic with..." posts, and then click to change the sort order.

Erik has a patch, gerrit 161101


Version: master
Severity: normal

Details

Reference
bz70982

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz70982.
bzimport added a subscriber: Unknown Object (MLST).

gerritadmin wrote:

Change 161158 had a related patch set uploaded by EBernhardson:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/161158

gerritadmin wrote:

Change 161158 merged by jenkins-bot:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/161158

gerritadmin wrote:

Change 162311 had a related patch set uploaded by EBernhardson:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/162311

gerritadmin wrote:

Change 162311 merged by jenkins-bot:
Don't run progressiveEnhancements through handlebars.js

https://gerrit.wikimedia.org/r/162311

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM