Page MenuHomePhabricator

CirrusSearch: insource highlighting
Closed, ResolvedPublic


We should highlight results of insource queries. If there is a regex in the query then we should only highlight regex matches. If there isn't a regex we should highlight whatever portion of the source matches.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:57 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz71057.
bzimport added a subscriber: Unknown Object (MLST).

Change 161611 had a related patch set uploaded by Manybubbles:
Highlighting for insource

Change 161611 merged by jenkins-bot:
Highlighting for insource

The code for this is merged but not yet deployed. The regex highlighting suffers from problems with multi byte characters (Bug 71126). The code to fix that has also been merged but it requires an Elasticsearch rolling restart which is a pain so it'll wait longer to be deployed.