Page MenuHomePhabricator
Create Task
Maniphest T73081

MassMessage LQT support broken
Closed, ResolvedPublic
Actions

Description

From bug comment 7:

It is not working anymore:
https://pt.wikibooks.org/wiki/Special:Log/massmessage?uselang=en

When I tried to send a message to
https://pt.wikibooks.org/wiki/Wikilivros_Discuss%C3%A3o:Caixa_de_areia
by creating this list
https://pt.wikibooks.org/w/index.php?title=Wikilivros:
Caixa_de_areia&oldid=273032
it showed
"Send mass message
Your message delivery to 1 page has been queued.
Send another message or view how many messages are queued."
but the message was not sent. There are now 6 queued mass messages on
https://pt.wikibooks.org/wiki/Special:Statistics?uselang=en

Version: unspecified
Severity: major

Details

Reference
bz71081

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:58 AM
• bzimport added a project: MassMessage.
• bzimport set Reference to bz71081.
Legoktm created this task.Sep 20 2014, 12:19 AM
Legoktm added a comment.Sep 20 2014, 12:20 AM

(In reply to Kunal Mehta (Legoktm) from comment #0)

From bug comment 7:

bug 52729 comment 7*

Legoktm added a comment.Sep 20 2014, 12:57 AM

I'm debugging this locally right now, it appears to be getting stuck at Thread::validateSubject() (via the LQT API) and my VM starts maxing out the CPU it has...

Legoktm added a comment.Sep 20 2014, 1:02 AM

Aaaand as I suspected it looks like Thread::validateSubject() for whatever reason is going into an infinite loop.

Legoktm added a comment.Sep 20 2014, 1:06 AM

error=MWException: Empty $mTitle in OutputPage::parse

Legoktm added a comment.Sep 20 2014, 1:17 AM

Threads::stripWikitext() calls $wgOut->parseInline() which dies if a Title isn't set.

gerritbot added a comment.Sep 20 2014, 1:22 AM

Change 161638 had a related patch set uploaded by Legoktm:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/161638

Nemo_bis added a comment.Sep 20 2014, 8:45 AM

(In reply to Gerrit Notification Bot from comment #6)

Change 161638 had a related patch set uploaded by Legoktm:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/161638

Bug 55739?

gerritbot added a comment.Sep 22 2014, 6:14 PM

Change 161638 merged by jenkins-bot:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/161638

Legoktm added a comment.Sep 22 2014, 6:17 PM

(In reply to Nemo from comment #7)

Bug 55739?

No, don't think it's related.

gerritbot added a comment.Sep 22 2014, 6:18 PM

Change 162003 had a related patch set uploaded by Legoktm:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/162003

gerritbot added a comment.Sep 22 2014, 6:19 PM

Change 162004 had a related patch set uploaded by Legoktm:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/162004

gerritbot added a comment.Sep 22 2014, 11:11 PM

Change 162004 merged by jenkins-bot:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/162004

gerritbot added a comment.Sep 22 2014, 11:36 PM

Change 162003 merged by EBernhardson:
ApiThreadAction: Make sure a Title is set

https://gerrit.wikimedia.org/r/162003

Legoktm added a comment.Sep 23 2014, 6:12 PM

Backported to WMF sites yesterday, confirmed working again: https://www.mediawiki.org/wiki/Thread:User_talk:Legoktm/LQT/Testing_lqt.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL