Page MenuHomePhabricator

All custom settings are ignored in book creation tool
Closed, ResolvedPublic

Description

If you select "1" under "columns" right before you generate the PDF of your book, the articles in the resulting file are still presented in a two-column layout.

Steps to reproduce

  1. Go to https://en.wikipedia.org/wiki/Eun_Heekyung
  2. Click "Create a book"
  3. Click "Start book creator"
  4. Click "Add this page to your book"
  5. Go to https://en.wikipedia.org/wiki/Viacheslav_Skok
  6. Click "Add this page to your book"
  7. Go to https://en.wikipedia.org/wiki/Special:Book
  8. Select "1" next to "columns"
  9. Click "Download as PDF" (and refresh the page if necessary)

The resulting PDF has two columns instead of one.


Version: unspecified
Severity: normal

Details

Reference
bz72003

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz72003.
pajz created this task.Oct 13 2014, 5:22 PM

Hm, the form on Special:Book has been split into three parts. That's not right. :(

gerritadmin wrote:

Change 167818 had a related patch set uploaded by Cscott:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167818

gerritadmin wrote:

Change 167818 merged by jenkins-bot:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167818

gerritadmin wrote:

Change 167845 had a related patch set uploaded by Reedy:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167845

gerritadmin wrote:

Change 167847 had a related patch set uploaded by Reedy:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167847

gerritadmin wrote:

Change 167847 merged by jenkins-bot:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167847

gerritadmin wrote:

Change 167845 merged by jenkins-bot:
Fix Book Creator settings (switch to JSON.stringify)

https://gerrit.wikimedia.org/r/167845

This patch was SWATted into production. Looks good.