Page MenuHomePhabricator

Hide the edit summary in Undelete for non-sysops, then grant "deletedhistory" to every user
Closed, DeclinedPublic

Assigned To
None
Authored By
bzimport
Mar 31 2006, 6:35 PM
Referenced Files
F2712: bug.5415.option.2.patch
Nov 21 2014, 9:11 PM
F2713: bug.5415.option.3.patch
Nov 21 2014, 9:11 PM
F2711: bug.5415.option.1.patch
Nov 21 2014, 9:11 PM
F2710: bug.5415.v1.patch
Nov 21 2014, 9:11 PM

Description

Author: rotemliss

Description:
I suggest to hide the edit summary in the page Undelete when shown to
non-sysops, so they will be able to see the deletion log, who edited the page
and when - but not the content of the edits, or the edit summaries.

Then I have three suggestions:

  1. To grant the permission "deletedhistory" to every user (*).
  2. To grant the permission "deletedhistory" to every registered user (user).
  3. To grant the permission "deletedhistory" to every autoconfirmed user

(autoconfirmed).

I will create a patch for the edit summary, and a patch for each suggestion, soon.


Version: 1.6.x
Severity: normal
URL: http://mail.wikipedia.org/pipermail/wikitech-l/2005-December/033283.html

Details

Reference
bz5415

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:11 PM
bzimport set Reference to bz5415.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

Patch for edit summaries

This patch edits the following files:

  • includes/SpecialUndelete.php - uses an "if" to decide whether to show the

summary or not.

  • languages/Messages.php - updates "undeletehistorynoadmin" to be more exact,

and to say that they also cannot view the edit summaries.

  • languages/MessagesHe.php - same as Messages.php, and also matches

"viewdeletedpage" to "undeletepage" - not connected, but should be done for
uniformity.

Now I will create a patch for every option.

Attached:

rotemliss wrote:

Patch for permissions - option 1

Attached:

rotemliss wrote:

Patch for permissions - option 2

Attached:

rotemliss wrote:

Patch for permissions - option 3

Attached:

rotemliss wrote:

Please check in the first patch, then choose among the second, third and fourth.

Wiki.Melancholie wrote:

*** Bug 5237 has been marked as a duplicate of this bug. ***

Wiki.Melancholie wrote:

Because I think (*) means anonymous users (IPs), I consider my bug
5237 ["Reactivate the permission for public history views of
deleted revisions (but without edit summaries)"] as a full
duplicate of this one.

rotemliss wrote:

(In reply to comment #7)

Because I think (*) means anonymous users (IPs), I consider my bug
5237 ["Reactivate the permission for public history views of
deleted revisions (but without edit summaries)"] as a full
duplicate of this one.

"*" means every user.

Wiki.Melancholie wrote:

Yes, I wanted to write "...means *also* anonymous users..."
So option 1 (Patch #2) would be my favourite.

mike.lifeguard+bugs wrote:

This seems inordinately stagnant. I assume the patches won't apply cleanly any longer. As this is perhaps a controversial change (and was discussed only for enwiki), I'd suggest closing this pending further discussion. If then there is still a desire to implement this, rewrite things.

I don't think there's really any use for this now, and if there is, there would still need to be a way to assign the right to see summaries to groups other than sysop. Can be reopened if there is a reason to do this in the future.