Page MenuHomePhabricator

Flow:cancel/confirm Hide action reloads Flow board/loads topic
Closed, ResolvedPublic

Description

  1. Login to beta labs.
  2. Visit a Flow board like http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow
  3. Open the browser developer console to the Net tab
  4. Choose Hide topic from a topic's action menu.
  5. Click Cancel in the "Please explain why you are hiding..." dialog

Result: there's a substantial delay while the Flow page reloads, and you jump to the top of the page.

The Cancel in other dialogs (Lock topic, Summarize) doesn't do this, the dialog just goes away without triggering a page reload.


Version: master
Severity: normal

Details

Reference
bz73005

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:48 AM
bzimport set Reference to bz73005.
bzimport added a subscriber: Unknown Object (MLST).

The Hide dialog operation is just weird. If I enter a reason in the dialog and then click [Hide], I'm prompted

"This page is asking you to confirm that you want to leave - data you have entered may not be saved."

if I confirm [Leave page] then the page *issues* a Post request to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Topic:S3dqqucjtbymepci&action=moderate-topic&topic_moderationState=hide . This replaces the Flow board with the topic alone showing "This topic was hidden by Spage beta."

in other words the page is not making an AJAX API request, it's visiting this URL as if JavaScript is disabled. Hence I guess the prompt about "data you have entered may not be saved."

I don't get this behavior if I log in to beta labs in a private window, nor do I get it in Chromium. I was getting it on regular page and with ?debug=1. I hope it's an unreproducible cosmic ray.