Page MenuHomePhabricator

Flow: API errors in Undo moderation aren't reported to the user
Closed, ResolvedPublic


I was trying to reproduce bug 73003.

  1. Login on beta labs
  2. Visit a Flow board and hide a topic.
  3. In another tab I logged out of beta labs.
  4. Then click Undo in the "This topic has been hidden _Undo_" moderated titlebar

Result: in the browser console Net tab the API response to the unhide operation is

"error":{"code":"permissions","info":"Insufficient permissions to execute this action.","permissions":null, ...

as expected. But there's no indication of failure in the UI, this error is not displayed anywhere.

Expected: the API failure displays in a pink errorbox near Undo.

On a local wiki you can replace step 3 with rename api.php to api_DISABLED.php; you'll see a 503 error in the Net tab.

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz73007.
bzimport added a subscriber: Unknown Object (MLST).

Change 171597 had a related patch set uploaded by Matthias Mullie:
Show error message when unable to undo moderation

Change 171597 merged by jenkins-bot:
Show error message when unable to undo moderation

When I click Undo I now see a pink errorbox above the "This topic has been deleted _Undo_" moderated titlebar.