Page MenuHomePhabricator
Create Task
Maniphest T76136

Special:AllPages broken on v1.24.0 (files renamed in include/AutoLoader.php but not in filesystem)
Closed, InvalidPublic
Actions

Description

Both SpecialAllpages.php and SpecialAllmessages.php have been changed to proper CamelCase in include/AutoLoader.php but haven't been renamed in the filesystem.

rMW2dc420dd2ae7c47984a15d84c06a57a684a7dd54 and rMWa161ea79a261ff80b4cfb79fe920bece5863cc79 are the commits which caused this.

Related Objects

Event Timeline

fbstj created this task.Nov 27 2014, 11:14 AM
fbstj raised the priority of this task from to Needs Triage.
fbstj updated the task description. (Show Details)
fbstj changed Security from none to None.
fbstj subscribed.
fbstj renamed this task from v1.24.0 include/AutoLoader.php breaks on Special:AllPages to Special:AllPages broken on v1.24.0.Nov 27 2014, 1:14 PM
fbstj updated the task description. (Show Details)
fbstj updated the task description. (Show Details)Nov 27 2014, 1:20 PM
Aklapper renamed this task from Special:AllPages broken on v1.24.0 to Special:AllPages broken on v1.24.0 (files renamed in include/AutoLoader.php but not in filesystem).Nov 27 2014, 1:27 PM
Aklapper triaged this task as High priority.
Aklapper added a project: MediaWiki-Special-pages.
Aklapper added subscribers: MarkAHershberger, Mglaser.
Mglaser added a comment.Nov 27 2014, 1:35 PM

Uh. How come this was not found by the unit tests? Anyways, this means a bugfix release next week.

Mglaser added a comment.Nov 27 2014, 1:43 PM

Hm. I just had a look in my copy of the tarball. I see

'SpecialAllPages' => 'includes/specials/SpecialAllPages.php',

in includes/AutoLoader.php l. 1021 and the file is named

SpecialAllPages.php

So the camelcaseing seems to be correct here. Could there be another reason for this behaviour?

fbstj added a comment.Nov 27 2014, 1:50 PM

Ahhhh, it's a windows/git problem, I copied the tarball into a windows git repo which didn't recognise the change then pulled it onto my linux host and it had the problem.

Mglaser added a comment.Nov 27 2014, 2:11 PM

That's good news for the tarball :) Can I close this bug then?

fbstj added a comment.Nov 27 2014, 2:17 PM

yeah, it's all my fault, sorry for worrying anyone

Mglaser closed this task as Resolved.Nov 27 2014, 2:19 PM
Mglaser claimed this task.
Aklapper changed the task status from Resolved to Invalid.Nov 27 2014, 2:20 PM
Aklapper subscribed.
gerritbot added a project: Patch-For-Review.Feb 7 2015, 6:09 PM
gerritbot subscribed.

Change 189232 had a related patch set uploaded (by Xqt):
Implement -wait option for checkimage.py

https://gerrit.wikimedia.org/r/189232

Patch-For-Review

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL