Page MenuHomePhabricator
Create Task
Maniphest T76458

item not found / invalid id exception from Special:EnitityData should not be logged
Closed, ResolvedPublic
Actions

Description

Item not found exception from Special:EnitityData should not be logged.

Example:

  1. https://www.wikidata.org/wiki/Special:EntityData/Q6069113.json

No entity with ID Q16537768 was found.

#0 /srv/mediawiki/php-1.25wmf9/extensions/Wikidata/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(372): Wikibase\Repo\LinkedData\EntityDataRequestHandler->getEntityRevision()
#1 /srv/mediawiki/php-1.25wmf9/extensions/Wikidata/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(226): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData()
#2 /srv/mediawiki/php-1.25wmf9/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialEntityData.php(154): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest()
#3 /srv/mediawiki/php-1.25wmf9/includes/specialpage/SpecialPage.php(363): Wikibase\Repo\Specials\SpecialEntityData->execute()
#4 /srv/mediawiki/php-1.25wmf9/includes/specialpage/SpecialPageFactory.php(589): SpecialPage->run()
#5 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(275): SpecialPageFactory::executePath()
#6 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(584): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(435): MediaWiki->main()
#8 /srv/mediawiki/php-1.25wmf9/index.php(46): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(3): include()
#10 {main}
  1. https://www.wikidata.org/wiki/Special:EntityData/Q1985727Precision11Before0After0

Invalid ID: Q1985727Precision11Before0After0.

#0 /srv/mediawiki/php-1.25wmf9/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialEntityData.php(154): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest('Q1985727Precisi...', Object(WebRequest), Object(OutputPage))
#1 /srv/mediawiki/php-1.25wmf9/includes/specialpage/SpecialPage.php(363): Wikibase\Repo\Specials\SpecialEntityData->execute('Q1985727Precisi...')
#2 /srv/mediawiki/php-1.25wmf9/includes/specialpage/SpecialPageFactory.php(589): SpecialPage->run('Q1985727Precisi...')
#3 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(275): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#4 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(584): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.25wmf9/includes/MediaWiki.php(435): MediaWiki->main()
#6 /srv/mediawiki/php-1.25wmf9/index.php(46): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
#8 {main}

Details

SubjectRepoBranchLines +/-
Revert "Introduce an UnloggedHttpError and use it in EntityDataRequestHandler"mediawiki/extensions/Wikibasemaster+13 -39
Introduce an UnloggedHttpError and use it in EntityDataRequestHandlermediawiki/extensions/Wikibasewmf/1.25wmf13+40 -13
Introduce an UnloggedHttpError and use it in EntityDataRequestHandlermediawiki/extensions/Wikibasewmf/1.25wmf12c+40 -13
Introduce an UnloggedHttpError and use it in EntityDataRequestHandlermediawiki/extensions/Wikibasemaster+40 -13
Customize query in gerrit

Related Objects

Event Timeline

JanZerebecki created this task.Dec 2 2014, 12:37 PM
JanZerebecki assigned this task to • Wikidata-bugs.
JanZerebecki raised the priority of this task from to High.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
JanZerebecki changed Security from none to None.
JanZerebecki subscribed.
JanZerebecki renamed this task from item not found exception from Special:EnitityData should not be logged to item not found / invalid id exception from Special:EnitityData should not be logged.Dec 2 2014, 12:47 PM
JanZerebecki updated the task description. (Show Details)
gerritbot added a project: Patch-For-Review.Jan 4 2015, 9:43 PM

Change 182750 had a related patch set uploaded (by Hoo man):
Don't log HttpErrors targeted at SpecialEntityData

https://gerrit.wikimedia.org/r/182750

Patch-For-Review

hoo subscribed.Jan 4 2015, 11:07 PM

These are hitting us at 500-700+ per minute since approx. January 2nd now!

JanZerebecki mentioned this in T85795: HttpError should not be logged as an unhandled exception..Jan 5 2015, 4:04 PM
gerritbot added a comment.Jan 5 2015, 4:21 PM

Change 182822 had a related patch set uploaded (by Hoo man):
Introduce an UnloggedHttpError and use it in EntityDataRequestHandler

https://gerrit.wikimedia.org/r/182822

Patch-For-Review

gerritbot added a comment.Jan 5 2015, 4:21 PM

Change 182823 had a related patch set uploaded (by Hoo man):
Introduce an UnloggedHttpError and use it in EntityDataRequestHandler

https://gerrit.wikimedia.org/r/182823

Patch-For-Review

hoo closed this task as Resolved.Jan 5 2015, 4:22 PM
gerritbot added a comment.Jan 5 2015, 4:35 PM

Change 182750 merged by jenkins-bot:
Introduce an UnloggedHttpError and use it in EntityDataRequestHandler

https://gerrit.wikimedia.org/r/182750

hoo mentioned this in rEWBA8f3f6455ab65: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler.Jan 5 2015, 4:35 PM
gerritbot added a comment.Jan 5 2015, 4:35 PM

Change 182823 merged by jenkins-bot:
Introduce an UnloggedHttpError and use it in EntityDataRequestHandler

https://gerrit.wikimedia.org/r/182823

gerritbot added a comment.Jan 5 2015, 4:35 PM

Change 182822 merged by jenkins-bot:
Introduce an UnloggedHttpError and use it in EntityDataRequestHandler

https://gerrit.wikimedia.org/r/182822

hoo mentioned this in rEWBAe57d9404318c: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler.Jan 5 2015, 4:36 PM
hoo mentioned this in rEWBA20cfe0694eff: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler.
JanZerebecki mentioned this in T90270: HttpError from line 359 of EntityDataRequestHandler.php.Feb 23 2015, 1:58 PM
Diffusion mentioned this in rMEXT9079c6531c2f: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:23 AM
gerritbot subscribed.Apr 5 2015, 12:49 AM

Change 201918 had a related patch set uploaded (by Hoo man):
Revert "Introduce an UnloggedHttpError and use it in EntityDataRequestHandler"

https://gerrit.wikimedia.org/r/201918

gerritbot added a comment.Apr 5 2015, 8:48 PM

Change 201918 merged by jenkins-bot:
Revert "Introduce an UnloggedHttpError and use it in EntityDataRequestHandler"

https://gerrit.wikimedia.org/r/201918

Diffusion mentioned this in rMEXTffd0fc9bd2c1: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Apr 5 2015, 8:49 PM
hoo mentioned this in rEWBA0d98d18f5898: Revert "Introduce an UnloggedHttpError and use it in EntityDataRequestHandler".Apr 5 2015, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits