Page MenuHomePhabricator

mVersion missing from User::__sleep() leading to constant cache miss
Closed, ResolvedPublic

Description

Author: netocrat

Description:
'mVersion' is missing from the array returned by User::__sleep() so that in
User::loadFromSession() even on a cache hit the check ($user->mVersion <
MW_USER_VERSION) evaluates true and a miss is assumed.

This is present in the current svn repository and seems to have been introduced
in CVS file version 1.162 of June 26 2006 tagged as 1_5beta1, where mVersion was
introduced but not added to __sleep return - which itself was only introduced
one file version earlier.

There also doesn't seem to be a specific component where this bug fits - how
about a new one: 'Caching'?


Version: 1.7.x
Severity: normal

Details

Reference
bz5728

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:11 PM
bzimport set Reference to bz5728.
bzimport added a subscriber: Unknown Object (MLST).