Page MenuHomePhabricator
Create Task
Maniphest T78057

Make the step UI and controller classes more self-contained
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Move detailsValid to details step controllermediawiki/extensions/UploadWizardmaster+95 -79
Move some upload step UI stuff out of ui.Wizardmediawiki/extensions/UploadWizardmaster+59 -74
Move some details UI stuff out of the Wizard UImediawiki/extensions/UploadWizardmaster+82 -75
Customize query in gerrit

Related Objects

Event Timeline

MarkTraceur created this task.Dec 9 2014, 8:48 PM
MarkTraceur claimed this task.
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: UploadWizard, Multimedia.
MarkTraceur changed Security from none to None.
MarkTraceur subscribed.
gerritbot added a project: Patch-For-Review.Dec 9 2014, 8:48 PM

Change 178604 had a related patch set uploaded (by MarkTraceur):
Move some details UI stuff out of the Wizard UI

https://gerrit.wikimedia.org/r/178604

Patch-For-Review

MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.Dec 9 2014, 8:48 PM
gerritbot added a comment.Dec 9 2014, 9:04 PM

Change 178642 had a related patch set uploaded (by MarkTraceur):
Move some upload step UI stuff out of ui.Wizard

https://gerrit.wikimedia.org/r/178642

Patch-For-Review

gerritbot added a comment.Dec 9 2014, 10:24 PM

Change 178672 had a related patch set uploaded (by MarkTraceur):
Move detailsValid to details step controller

https://gerrit.wikimedia.org/r/178672

Patch-For-Review

MarkTraceur moved this task from Next up to Needs code review on the Multimedia board.Dec 10 2014, 7:40 PM
gerritbot added a comment.Dec 15 2014, 2:01 PM

Change 178604 merged by jenkins-bot:
Move some details UI stuff out of the Wizard UI

https://gerrit.wikimedia.org/r/178604

• Gilles mentioned this in rEUWI3f1000a86b47: Move some details UI stuff out of the Wizard UI.Dec 15 2014, 2:02 PM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 15 2014, 2:02 PM
gerritbot added a comment.Dec 17 2014, 11:02 AM

Change 178642 merged by jenkins-bot:
Move some upload step UI stuff out of ui.Wizard

https://gerrit.wikimedia.org/r/178642

MarkTraceur mentioned this in rEUWI59ebd690cab6: Move some upload step UI stuff out of ui.Wizard.Dec 17 2014, 11:02 AM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 17 2014, 2:51 PM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 17 2014, 5:09 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 24 2014, 4:06 PM
gerritbot added a comment.Jan 5 2015, 4:44 PM

Change 178672 merged by jenkins-bot:
Move detailsValid to details step controller

https://gerrit.wikimedia.org/r/178672

• Gilles mentioned this in rEUWI6b653c377fbe: Move detailsValid to details step controller.Jan 5 2015, 4:47 PM
• Gilles moved this task from Needs code review to Next up on the Multimedia board.Jan 8 2015, 5:34 AM
MarkTraceur added a comment.Jan 12 2015, 2:42 PM

Still need tests for Firefogg (which is why this is still in the current sprint). All other patches merged.

MarkTraceur added a project: Multimedia-Sprint-2015-03-04.Mar 4 2015, 5:19 PM
MarkTraceur mentioned this in rMEXTe9094fabf338: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:22 AM
Diffusion mentioned this in rMEXT96dfdfdaad62: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:22 AM
Diffusion mentioned this in rMEXT889e4cbe99ea: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
• Gilles edited projects, added Multimedia-Sprint-2015-03-11; removed Multimedia-Sprint-2015-03-04.Mar 11 2015, 4:22 PM
MarkTraceur added a subscriber: • Gilles.Mar 13 2015, 4:16 PM

Wait, that comment was on the wrong bug. @Gilles do you remember why this wasn't closed?

• Gilles closed this task as Resolved.Mar 15 2015, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits