Page MenuHomePhabricator
Create Task
Maniphest T78299

Add a method to remove statements
Closed, DeclinedPublic
Actions

Description

"(...) My first idea was to mirror the existing StatementList::addStatement( Statement $statement ) and introduce StatementList::removeStatement( Statement $statement ). But that's not very helpful. This method is barely used. In tests we use addNewStatement. How to remove such statements?

More convenience methods in Item? Probably not a good idea.

How to empty a StatementList? Item::setStatements( new StatementList() ) is possible but a bit ugly. Should there be a StatementList::clear()?"

https://github.com/wmde/WikibaseDataModel/issues/175

Related Objects

Event Timeline

Lucie created this task.Dec 11 2014, 3:24 PM
Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie added projects: Wikibase-DataModel, Wikidata.
Lucie changed Security from none to None.
Lucie subscribed.
thiemowmde subscribed.Dec 11 2014, 4:08 PM

Most simple idea to partly fix this is to add support for setStatements( null ), but I'm not 100% sure about this idea because this can be misread and be confusing, see https://github.com/wmde/WikibaseDataModel/pull/293.

thiemowmde added a comment.May 4 2015, 1:27 PM

I suggest to close this per argument in https://github.com/wmde/WikibaseDataModel/issues/446#issuecomment-98703957.

thiemowmde closed this task as Declined.May 5 2015, 12:43 PM
thiemowmde claimed this task.
thiemowmde mentioned this in T98143: Add methods to remove Statements from a StatementList.May 5 2015, 2:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL