Page MenuHomePhabricator

Bug: Flow Preview is displaying both the preview and the editing box
Closed, ResolvedPublic

Description

On Mediawiki: Preview is displaying both the preview and the editing box. This makes the "Keep editing" button a baffling concept, because you can keep editing where you are. We should hide the editing box again.


PS. I know that Quiddity and Hhhippo have suggested that we actually show both the preview and the editing box -- it's not a bad idea, and we can talk about adding that later, maybe with a "Refresh the preview" button. But breaking something and then moving stuff around the breakage isn't a great development plan. :) Let's fix the bug and then talk about the change.

Event Timeline

DannyH created this task.Dec 16 2014, 11:50 PM
DannyH raised the priority of this task from to Normal.
DannyH updated the task description. (Show Details)
DannyH added a project: StructuredDiscussions.
DannyH changed Security from none to None.
DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.
DannyH added a subscriber: DannyH.

quiddity listed this under features :)

Yeah, I know. But I don't think that's how it works. :)

DannyH updated the task description. (Show Details)Dec 16 2014, 11:59 PM
Spage raised the priority of this task from Normal to High.Dec 17 2014, 8:06 PM
Spage renamed this task from Bug: Preview is displaying both the preview and the editing box to Bug: Flow Preview is displaying both the preview and the editing box.Dec 17 2014, 8:40 PM

Change 180738 had a related patch set uploaded (by Matthias Mullie):
Hide inputs on preview

https://gerrit.wikimedia.org/r/180738

Patch-For-Review

Change 180738 merged by jenkins-bot:
Hide inputs on preview

https://gerrit.wikimedia.org/r/180738

Change 180978 had a related patch set uploaded (by Mattflaschen):
Hide inputs on preview

https://gerrit.wikimedia.org/r/180978

Patch-For-Review

Change 180979 had a related patch set uploaded (by Mattflaschen):
Hide inputs on preview

https://gerrit.wikimedia.org/r/180979

Patch-For-Review

Change 180978 merged by jenkins-bot:
Hide inputs on preview

https://gerrit.wikimedia.org/r/180978

Change 180979 merged by jenkins-bot:
Hide inputs on preview

https://gerrit.wikimedia.org/r/180979