Bug: Flow Preview is displaying both the preview and the editing box
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• DannyH
	Dec 16 2014, 11:50 PM

Description

On Mediawiki: Preview is displaying both the preview and the editing box. This makes the "Keep editing" button a baffling concept, because you can keep editing where you are. We should hide the editing box again.

PS. I know that Quiddity and Hhhippo have suggested that we actually show both the preview and the editing box -- it's not a bad idea, and we can talk about adding that later, maybe with a "Refresh the preview" button. But breaking something and then moving stuff around the breakage isn't a great development plan. :) Let's fix the bug and then talk about the change.

new_topic_preview.jpg (576×802 px, 130 KB)

Details

Subject	Repo	Branch	Lines +/-
Hide inputs on preview	mediawiki/extensions/Flow	wmf/1.25wmf13	+2 -2
Hide inputs on preview	mediawiki/extensions/Flow	wmf/1.25wmf12	+2 -2
Hide inputs on preview	mediawiki/extensions/Flow	master	+2 -2

Customize query in gerrit

Revisions and Commits

rEFLW extension-Flow
	rEFLWa43abe2c87cd Hide inputs on preview
	rEFLWc085bcd7ed6c Hide inputs on preview
	rEFLW1d045731023e Hide inputs on preview
	rEFLW6e79811f3f6b Hide inputs on preview
rMEXT MediaWiki Extensions
	rMEXTb3cd5a6b119a Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Event Timeline

• DannyH created this task.Dec 16 2014, 11:50 PM

• DannyH raised the priority of this task from to Medium.

• DannyH updated the task description. (Show Details)

• DannyH added a project: StructuredDiscussions.

• DannyH changed Security from none to None.

• DannyH added a project: Collaboration-Team-Triage.

• DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.

• DannyH subscribed.

quiddity listed this under features :)

Yeah, I know. But I don't think that's how it works. :)

• DannyH updated the task description. (Show Details)Dec 16 2014, 11:59 PM

• Mattflaschen-WMF assigned this task to matthiasmullie.Dec 17 2014, 7:25 PM

• Mattflaschen-WMF subscribed.

• Spage moved this task from Team discussion to Ready for next sprint on the Collaboration-Team-Triage board.Dec 17 2014, 7:29 PM

• Spage raised the priority of this task from Medium to High.Dec 17 2014, 8:06 PM

• Spage added a project: Collaboration-Team-Sprint-M-2014-12-17.

• Spage moved this task from Sprint N (ends Dec 30) to In Development on the Collaboration-Team-Sprint-M-2014-12-17 board.

• Spage renamed this task from Bug: Preview is displaying both the preview and the editing box to Bug: Flow Preview is displaying both the preview and the editing box.Dec 17 2014, 8:40 PM

• Spage removed a project: Collaboration-Team-Triage.Dec 17 2014, 9:33 PM

matthiasmullie moved this task from In Development to Code Review on the Collaboration-Team-Sprint-M-2014-12-17 board.Dec 18 2014, 9:19 AM

Change 180738 had a related patch set uploaded (by Matthias Mullie):
Hide inputs on preview

https://gerrit.wikimedia.org/r/180738

Patch-For-Review

Change 180738 merged by jenkins-bot:
Hide inputs on preview

https://gerrit.wikimedia.org/r/180738