Page MenuHomePhabricator

Possible missing cache invalidation for user alerts
Closed, InvalidPublic

Description

Author: netocrat

Description:
The two calls to $wgOut->setSquidMaxage(0) in outputPage() in SkinTemplate.php
whilst setting up 'newtalk' alerts aren't accompanied by a call to
$wgOut->enableClientCache(false) as occurs in the corresponding code in
Skin.php. This seems to prevent alert messages from disappearing when a page is
reloaded after alerts should have been cleared by viewing the user talk page.

This applies at least as far back as release 1.5.6.


Version: 1.7.x
Severity: normal

Details

Reference
bz5926

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:13 PM
bzimport set Reference to bz5926.
bzimport added a subscriber: Unknown Object (MLST).

Do you mean, for anonymous users? Logged-in users will already be covered by the user_touched update.

netocrat wrote:

:-)

Actually, I'm not sure what I meant now - the call serves a purpose in Skin.php
but would serve no purpose in SkinTemplate.php. Excuse this report, it was
based on a memory from an experience a day ago that I (clearly) didn't verify as
reproducible.