Page MenuHomePhabricator

Generated style sheets have wrong cache control settings for logged-in users
Closed, ResolvedPublic

Description

Author: dunc_harris

Description:
Nasty looking funny? question marks have started to appear? next to redlinks.
This disrupts the flow of? text because you don't? want random question? marks
throughout a sentence. What was wrong? with the old way?? Isn't there
something ''bro?ken'' that needs fixing?


Version: unspecified
Severity: normal

Details

Reference
bz6037

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:18 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz6037.
bzimport added a subscriber: Unknown Object (MLST).

dean wrote:

From your bug report (full of qurstion marks), it looks like something screwey
with your computer or browser, not the websites.

robchur wrote:

  1. Check you haven't enabled the alternate broken link display in your preferences
  2. Hard-refresh your browser and/or clear your cache
  3. If the problem persists, please reopen this bug report and send a screenshot

dunc_harris wrote:

No, it came on momentarily and then went off again. I think it was someone
messing with the settings for some unfathomable reason. The questoin marks in
the report were supposed to be illustrative.

robchur wrote:

Sounds like some corrupt CSS was loaded, which is frequent enough to be
irritating, but isn't a problem we can fix per se.

dunc_harris wrote:

They're back. Redlinks have turned black, lost their underlining and have
acquired question marks at the end of them.

robchur wrote:

(In reply to comment #5)

They're back. Redlinks have turned black, lost their underlining and have
acquired question marks at the end of them.

You checked the user preference again?

Please provide your username and the URL to the wiki on which
you see this effect.

dunc_harris wrote:

My username is Duncharris. I'm running default Monobook on Firefox (I'll try
upgrading Firefox and see if it has an effect).

No-one's given me a monobook.js present (if that's possible).

dunc_harris wrote:

I've resaved my preferences and it's working okay now. Something straneg was
happening becaus I didn't touch my prefs.

Generated JS is sending incorrect cache control headers,
which could cause people to sometimes see the wrong style
settings:

Cache-Control: s-maxage=2678400, max-age=2678400
Vary: Accept-Encoding

It should probably look more like:

Cache-Control: s-maxage=0, max-age=2678400
Vary: Accept-Encoding, Cookie

robchur wrote:

Brion fixed this some time ago, and the fix seems to have worked; we haven't had
reports of the behaviour since.

robchur wrote:

*** Bug 2127 has been marked as a duplicate of this bug. ***