Page MenuHomePhabricator

Add extra spacing to preferences items to make them clearer to read
Closed, DeclinedPublic

Description

Author: ivan

Description:
There is an extra newline on watchlist tab options separating
"prefs-watchlist-days" and "tog-extendwatchlist", while on other tabs there is
no such newline. Please remove it for consistency in interface.


Version: unspecified
Severity: enhancement

Details

Reference
bz6045

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:18 PM
bzimport set Reference to bz6045.
bzimport added a subscriber: Unknown Object (MLST).

ivan wrote:

Remove extra spacing on watchlist tab on Special:Preferences

attachment SpecialPreferences.patch ignored as obsolete

robchur wrote:

I don't understand why you'd want to remove it and cramp up the interface. It
makes much more sense to me to add extra spacing and made the controls clearer
and easier to use.

ivan wrote:

The reason is consistency on user interface.

  • On the "Recent changes" tab, there's no space between entry of "Titles in recent changes" and check box

for "Hide minor edits in recent changes"

  • On the "Editing" tab, there's no space between entry of "Rows" and "Cols" and check box for "Enable

sections editing..."

  • On the "Misc" tab, there's no space between entry of "Underline links" and check box for "Format broken

links..."

But suddenly, there's a space between "Number of days to show in watchlist:" and "Hide my edits from the
watchlist". If user navigate between the tabs, they'll notice the difference in the interface. IMHO, it
better be consistent. Either add extra newline on the three other tabs, or remove the extra newline on
the "Watchlist" tab.

robchur wrote:

Changing summary to reflect the real issue.

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

john wrote:

Comment on attachment 1815
Remove extra spacing on watchlist tab on Special:Preferences

Thanks for submitting a patch to MediaWiki. Unfortunately I'm going to have to
mark the patch as obsolete because it no longer merges into our current code.

john wrote:

Also, closing as WFM since the new preferences system doesn't seem to have this problem.