Page MenuHomePhabricator

PageCSS doesn't work when parser cache is on
Closed, ResolvedPublic

Description

Author: suisui

Description:
using PageCSS, when preview, it works well.
but after save it, it doesn't work.

That's because parser cache doesn't see page css.

This extension is very useful for make a site with MediaWiki. I highly recommend
to fix it. Thanx.


Version: unspecified
Severity: normal

Details

Reference
bz6267

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 9:19 PM
bzimport set Reference to bz6267.
bzimport added a subscriber: Unknown Object (MLST).

Indeed, that won't work.

Also the extension as written is insecure; do not use it on a
publicly editable wiki.

No, the extension should be fixed: for now it could disable
parser cache on pages where it's used.

ezyang wrote:

Temporary fix by disabling page cache.

Attached:

Fixed in r15244. I moved the disableCache() call into the
actual hook function so it won't disable caching for pages
that don't use it.

(Note there are still potential problems with this extension.)