Page MenuHomePhabricator

Protect page: "Unlock move permissions" appears when "move" is not an option
Closed, DeclinedPublic

Description

Author: nashtrash1

Description:
The checkbox "Unlock move permissions" appears even though the ability to change
move permissions was removed by setting "$wgRestrictionTypes = array ('edit');"
in LocalSettings.


Version: 1.7.x
Severity: normal
OS: Windows XP
Platform: PC
URL: http://static.flickr.com/51/183372225_5152f00bf5_o.png

Details

Reference
bz6571

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:19 PM
bzimport set Reference to bz6571.
bzimport added a subscriber: Unknown Object (MLST).

nashtrash1 wrote:

patch for skins/common/protect.js to make "unlock move permissions" checkbox and label invisible when one or fewer checkboxes

This patch sets the style property "display: none" to the checkbox and label
corresponding to "unlock move permissions" if one or fewer select boxes are on
the page. For a screenshot with the patch applied, see
http://static.flickr.com/67/183375885_ee0baa4e09_o.png

Attached:

robchur wrote:

Don't just hide the checkbox, remove it from the form completely and stop the
input from being checked.

rotemliss wrote:

r15375, using a patch to the PHP instead of a patch to the JavaScript (using CSS).

rotemliss wrote:

Reverted, as it causes a JavaScript alertbox when changing the list box when
disabling the move change. The protection code is currently unsuitable for those
configuration settings.

No longer seems to be the case