Page MenuHomePhabricator
Create Task
Maniphest T86862

Investigate/prevent master revision query on enwiki edit form
Closed, ResolvedPublic
Actions

Description

Seeing it on frwiki and dewiki, but not locally. Maybe some extension causes it?

Related: https://gerrit.wikimedia.org/r/#/c/185372/

Details

SubjectRepoBranchLines +/-
Removed newFromConds master fallback logic; obsoleted by $flagsmediawiki/coremaster+0 -10
Made master connection expectations actually workmediawiki/coremaster+4 -4
Added query/connection expectation support to TransactionProfilermediawiki/coremaster+109 -0
Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Jan 15 2015, 12:22 AM
aaron claimed this task.
aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron added a project: MediaWiki-Core-Team.
aaron moved this task to In Dev/Progress on the MediaWiki-Core-Team board.
aaron subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2015, 12:22 AM
aaron updated the task description. (Show Details)Jan 15 2015, 12:54 AM
aaron set Security to None.
aaron updated the task description. (Show Details)Jan 20 2015, 10:24 PM
gerritbot added a project: Patch-For-Review.Feb 10 2015, 6:25 PM
gerritbot subscribed.

Change 185342 had a related patch set uploaded (by Aaron Schulz):
Added query/connection expectation support to TransactionProfiler

https://gerrit.wikimedia.org/r/185342

Patch-For-Review

gerritbot added a comment.Feb 12 2015, 9:39 PM

Change 185342 merged by jenkins-bot:
Added query/connection expectation support to TransactionProfiler

https://gerrit.wikimedia.org/r/185342

aaron mentioned this in rMW505394a5a935: Added query/connection expectation support to TransactionProfiler.Feb 12 2015, 9:39 PM
gerritbot added a comment.Mar 3 2015, 9:17 PM

Change 194184 had a related patch set uploaded (by Aaron Schulz):
Made master connection expectations actually work

https://gerrit.wikimedia.org/r/194184

gerritbot added a comment.Mar 4 2015, 5:26 AM

Change 194184 merged by jenkins-bot:
Made master connection expectations actually work

https://gerrit.wikimedia.org/r/194184

aaron mentioned this in rMWc39a4530b0cc: Made master connection expectations actually work.Mar 4 2015, 5:27 AM
gerritbot added a comment.Mar 11 2015, 3:53 AM

Change 195842 had a related patch set uploaded (by Aaron Schulz):
Removed newFromConds master fallback logic; obsoleted by $flags

https://gerrit.wikimedia.org/r/195842

aaron renamed this task from Investigate master revision query on enwiki edit form to Investigate/prevent master revision query on enwiki edit form.Mar 11 2015, 4:12 AM
aaron moved this task from In Dev/Progress to Needs Review/Feedback on the MediaWiki-Core-Team board.
gerritbot added a comment.Mar 13 2015, 6:01 PM

Change 195842 merged by jenkins-bot:
Removed newFromConds master fallback logic; obsoleted by $flags

https://gerrit.wikimedia.org/r/195842

aaron moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.Mar 13 2015, 6:05 PM
bd808 closed this task as Resolved.Mar 16 2015, 9:11 PM
bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.
aaron mentioned this in rMW3c2bc32ae177: Removed newFromConds master fallback logic; obsoleted by $flags.Mar 23 2015, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits