Maniphest T87193

EditorOverlays should use events property for their event bindings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 19 2015, 7:42 PM

Tags

Referenced Files

None

Subscribers

Description

They currently use this.$( '.selector' ).on instead

VisualEditorOverlay, EditorOverlayBase and EditorOverlay

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: Use events map in overlay files	mediawiki/extensions/MobileFrontend	master	+96 -50

Customize query in gerrit

Related Objects

Mentioned In: rMEXTe9915d273f19: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFRcb16306c4e05: Hygiene: Use events map in overlay files

Event Timeline

Jdlrobson created this task.Jan 19 2015, 7:42 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2015, 7:42 PM

• bmansurov claimed this task.Jan 19 2015, 10:41 PM

• bmansurov set Security to None.

Change 185929 had a related patch set uploaded (by Bmansurov):
Use events map in overlay files

https://gerrit.wikimedia.org/r/185929

Patch-For-Review

• bmansurov moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Jan 19 2015, 11:10 PM

Jdlrobson moved this task from Needs Prioritization to Product Owner Backlog on the Web-Team-Backlog board.Jan 20 2015, 6:40 PM

• bmansurov moved this task from Product Owner Backlog to Needs Prioritization on the Web-Team-Backlog board.Jan 23 2015, 9:07 PM

Jdlrobson moved this task from Needs Prioritization to Product Owner Backlog on the Web-Team-Backlog board.Jan 28 2015, 11:19 PM

• bmansurov moved this task from Product Owner Backlog to Needs Prioritization on the Web-Team-Backlog board.Jan 29 2015, 6:40 PM

Change 185929 merged by jenkins-bot:
Hygiene: Use events map in overlay files

https://gerrit.wikimedia.org/r/185929

Jdlrobson mentioned this in rEMFRcb16306c4e05: Hygiene: Use events map in overlay files.Jan 29 2015, 9:08 PM

Jdlrobson closed this task as Resolved.Jan 29 2015, 9:17 PM

Diffusion mentioned this in rMEXTe9915d273f19: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:25 AM

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:27 AM