Page MenuHomePhabricator
Create Task
Maniphest T89673

MediaWiki returns Cache-Control: private for all HTTPS requests
Closed, ResolvedPublic
Actions

Description

This code:

in_array( $request->getFullRequestURL(), $requestTitle->getSquidURLs() )

is used to determine whether the current URL is cacheable. But for HTTPS views, getFullRequestURL() returns an HTTPS URL while getSquidURLs() returns an array of HTTP URLs, so the in_array() call will never return true and the request will never be considered cacheable.

This means cache misses from HTTPS users are never used to populate the cache :(

Details

SubjectRepoBranchLines +/-
Fix URL comparison used for cacheability decisionmediawiki/corewmf/1.25wmf16+5 -1
Fix URL comparison used for cacheability decisionmediawiki/coremaster+5 -1
Fix URL comparison used for cacheability decisionmediawiki/corewmf/1.25wmf17+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Feb 16 2015, 8:30 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added projects: HTTPS, HTTPS-by-default.
Catrope subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2015, 8:30 PM
gerritbot added a project: Patch-For-Review.Feb 16 2015, 8:31 PM
gerritbot subscribed.

Change 190853 had a related patch set uploaded (by Catrope):
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190853

Patch-For-Review

Nemo_bis added a project: MediaWiki-General.Feb 16 2015, 8:40 PM
Nemo_bis set Security to None.
Krenair subscribed.Feb 16 2015, 8:41 PM
gerritbot added a comment.Feb 16 2015, 9:36 PM

Change 190853 merged by jenkins-bot:
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190853

ori mentioned this in rMWc7c1c4edbff0: Fix URL comparison used for cacheability decision.Feb 16 2015, 9:36 PM
gerritbot added a comment.Feb 16 2015, 9:42 PM

Change 190937 had a related patch set uploaded (by Catrope):
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190937

Patch-For-Review

gerritbot added a comment.Feb 16 2015, 9:48 PM

Change 190937 merged by jenkins-bot:
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190937

Catrope mentioned this in rMW5ccbf111c2ca: Fix URL comparison used for cacheability decision.Feb 16 2015, 9:49 PM
gerritbot added a comment.Feb 16 2015, 10:21 PM

Change 190945 had a related patch set uploaded (by Catrope):
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190945

Patch-For-Review

gerritbot added a comment.Feb 16 2015, 10:27 PM

Change 190945 merged by jenkins-bot:
Fix URL comparison used for cacheability decision

https://gerrit.wikimedia.org/r/190945

Catrope mentioned this in rMW8a6f9af7a6e3: Fix URL comparison used for cacheability decision.Feb 16 2015, 10:27 PM
Aklapper triaged this task as Medium priority.Feb 17 2015, 9:57 AM
faidon mentioned this in T89755: (Some) URLs containing URL-encoded characters(?) are uncacheable.Feb 17 2015, 8:24 PM
Catrope closed this task as Resolved.Feb 22 2015, 9:52 PM
Catrope claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL