Is there any reason to not show the user preference option to hide patrolled pages at Special:NewPages when RC patrol is disabled ?
Shouldn't this check for NP patrol instead ?
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Adjusting patrol checks for RC and watchlist prefs | mediawiki/core | master | +4 -1 |
Related Objects
Event Timeline
It is using NP patrol check, but the option is only visible when the user is allow to set or see patrol marks
I'm talking about the pref option, which is defined at Preferences.php. It uses the RC check. I'm an admin at enwiki and can see no NP preference option, but I'm also an admin at testwiki and I can see both RC and NP.
Okay, you are talking about user option 'newpageshidepatrolled' on Special:Preferences. At first look it seems okay to adjust the check.
Looking at option 'watchlisthidepatrolled' (for Special:WatchList) there is another check, maybe needs also adjust to avoid showing that for user not allowing to patrol (or not having the option on Special:Watchlist).
Change 191122 had a related patch set uploaded (by Cenarium):
Adjusting patrol checks for RC and watchlist prefs
Change 191122 merged by jenkins-bot:
Adjusting patrol checks for RC and watchlist prefs
Fix will be part of MediaWiki1.25wmf19, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the timeline