Page MenuHomePhabricator

New Page patrolling user preference option not shown when RC patrol disabled
Closed, ResolvedPublic

Description

Is there any reason to not show the user preference option to hide patrolled pages at Special:NewPages when RC patrol is disabled ?
Shouldn't this check for NP patrol instead ?

Event Timeline

Cenarium created this task.Feb 17 2015, 2:39 PM
Cenarium raised the priority of this task from to Medium.
Cenarium updated the task description. (Show Details)
Cenarium added a project: MediaWiki-Patrolling.
Cenarium added a subscriber: Cenarium.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2015, 2:39 PM

It is using NP patrol check, but the option is only visible when the user is allow to set or see patrol marks

I'm talking about the pref option, which is defined at Preferences.php. It uses the RC check. I'm an admin at enwiki and can see no NP preference option, but I'm also an admin at testwiki and I can see both RC and NP.

Okay, you are talking about user option 'newpageshidepatrolled' on Special:Preferences. At first look it seems okay to adjust the check.

Looking at option 'watchlisthidepatrolled' (for Special:WatchList) there is another check, maybe needs also adjust to avoid showing that for user not allowing to patrol (or not having the option on Special:Watchlist).

Indeed.
So it's okay if I make a commit fixing both issues ?

Yes, just calling it about adjusting patrol checks on preferences or so.

gerritbot added a subscriber: gerritbot.

Change 191122 had a related patch set uploaded (by Cenarium):
Adjusting patrol checks for RC and watchlist prefs

https://gerrit.wikimedia.org/r/191122

Patch-For-Review

Change 191122 merged by jenkins-bot:
Adjusting patrol checks for RC and watchlist prefs

https://gerrit.wikimedia.org/r/191122

Umherirrender closed this task as Resolved.Feb 18 2015, 8:24 PM
Umherirrender assigned this task to Cenarium.
Umherirrender set Security to None.

Fix will be part of MediaWiki1.25wmf19, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the timeline