Page MenuHomePhabricator

When using core's deletion interface (action=delete), appears to work but topics are not actually deleted
Closed, ResolvedPublic

Description

When you use core's deletion interface (e.g. http://127.0.0.1:8080/w/index.php?title=Topic:Sc74aet4uq42fd4y&action=delete) it appears to work (except for a useless message analogous to T90971), but the topic is still accessible with the normal URL, and visible on the board.

We should either block this, or map it to Flow's internal deletion. I'll put up a quick fix to block it.

Event Timeline

Mattflaschen-WMF raised the priority of this task from to Needs Triage.
Mattflaschen-WMF updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2015, 2:26 AM

Change 193554 had a related patch set uploaded (by Mattflaschen):
Block the user from the using the action=delete interface for topics.

https://gerrit.wikimedia.org/r/193554

This is a quick fix. I have a couple thoughts on better solutions:

  1. Redirect the action=delete page to the Flow no-JS deletion UI
  2. Just let them use the normal action=delete UI, but hook into core so it has a different effect (not sure yet how to block core from deleting the Topic page without giving a user-visible error message).
Mattflaschen-WMF triaged this task as Normal priority.Feb 28 2015, 4:34 AM

Change 193554 merged by jenkins-bot:
Block the user from the using the action=delete interface for topics.

https://gerrit.wikimedia.org/r/193554

Mattflaschen-WMF closed this task as Resolved.Jun 25 2015, 10:32 PM