Page MenuHomePhabricator

Add scrollable element to collections content overlay
Closed, ResolvedPublic

Description

For wrapping up: https://phabricator.wikimedia.org/T91296
collections content overlay should have scroll for users with multiple lists. Scroll starts on line after “add to existing collection”

Event Timeline

JKatzWMF raised the priority of this task from to Needs Triage.
JKatzWMF updated the task description. (Show Details)
JKatzWMF added a project: Gather Sprint C_.
JKatzWMF subscribed.
rmoen set Security to None.
rmoen moved this task from Ready for dev to In development on the Gather Sprint C_ board.
rmoen renamed this task from add to watchlist overlay scroll to Add scrollable element to collections content overlay.Mar 10 2015, 5:54 PM
rmoen updated the task description. (Show Details)

Change 195638 had a related patch set uploaded (by Robmoen):
Add scrollable element to collections content overlay

https://gerrit.wikimedia.org/r/195638

@JKatzWMF is it essential for just that part of overlay to scroll? It might be easier for time being to make entire thing scrollable.

Look at iPhone 4 for example - that's not much scrolling room and we are not even showing the text extract in that example which pushes it down further!

Screen_Shot_2015-03-10_at_1.01.58_PM.png (486×317 px, 33 KB)

I added a patch to make the form on a single line but as you can see this still is a little cramped (and there are much smaller devices than iphone 4)

Screen_Shot_2015-03-10_at_1.16.26_PM.png (487×319 px, 60 KB)

This comment was removed by Jdlrobson.

Change 195784 had a related patch set uploaded (by Robmoen):
Make collection content overlay scrollable

https://gerrit.wikimedia.org/r/195784

Change 195638 abandoned by Robmoen:
Add scrollable element to collections content overlay

Reason:
Abandoning in favor of https://gerrit.wikimedia.org/r/#/c/195784/

https://gerrit.wikimedia.org/r/195638

As a first pass we've made the entire thing scrollable. We know it's not exactly what you want but it makes the feature useable and we can iterate off that.

Change 195784 merged by jenkins-bot:
Make collection content overlay scrollable

https://gerrit.wikimedia.org/r/195784

There seems to be a limit to the scrolling then the page starts to scroll (As shown here on phone screenshot where my hello kitty kitty collection wont appear):

Screenshot_2015-03-13_13.24.53.png (468×261 px, 53 KB)

Desktop seems even jenkier.

@Jdlrobson FYI ^ ---nevermind, created bug to rep this: T92791

New bug created in next sprint. This is not done though.