Page MenuHomePhabricator

Cleanup and document login and create messages left from vform work
Closed, InvalidPublic

Description

We unintentionally left some cruft in when removing the old login and create account forms.

Specifically, loginstart, loginend, signupstart, signupend (and possibly others) were removed from use, but not removed entirely. This also needs to be documented at https://www.mediawiki.org/wiki/Account_creation_user_experience/Strings#Removed_old_messages

See also T58455: Text at MediaWiki:Signupstart not shown


Trello card: fPSXLKrn

  • column: Bucket o' Mess
  • labels: Technical Debt & Refactoring (orange)

Event Timeline

matmarex subscribed.

Specifically, loginstart, loginend, signupstart, signupend (and possibly others) were removed from use, but not removed entirely.

loginstart and loginendwere removed in 2014 in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/151536

signupstart and signupend are still in use today, MediaWiki supports them and they have a few overrides on Wikimedia wikis. Maybe support for them was restored after the initial deployment or something.