Maniphest T92608

Download menu broken (because beta cached broken data)
Closed, InvalidPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	• Gilles
	Mar 13 2015, 8:25 AM

Tags

Referenced Files

	F87803: Screenshot_2015-03-13_09.41.00.png
	Mar 13 2015, 8:43 AM

Subscribers

Description

Seen in browser tests across all browsers:

https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/517/testReport/junit/%28root%29/Download%20menu/Image_size_defaults_to_original/

https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/362/testReport/junit/%28root%29/Download%20menu/Image_size_defaults_to_original/

https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/518/testReport/junit/%28root%29/Download%20menu/Image_size_defaults_to_original/

https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/521/testReport/junit/%28root%29/Download%20menu/Image_size_defaults_to_original/

Reproduced it on beta:

Screenshot_2015-03-13_09.41.00.png (287×507 px, 15 KB)

I see a JS error in the console worth investigating:

mmv.ui.metadataPanel.js:466 Uncaught TypeError: undefined is not a function

Event Timeline

• Gilles created this task.Mar 13 2015, 8:25 AM

• Gilles claimed this task.

• Gilles raised the priority of this task from to High.

• Gilles updated the task description. (Show Details)

• Gilles added projects: MediaViewer, Multimedia-Sprint-2015-03-11.

• Gilles subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptMar 13 2015, 8:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Gilles renamed this task from Download browser test failure to Download menu broken.Mar 13 2015, 8:43 AM

• Gilles raised the priority of this task from High to Unbreak Now!.

• Gilles updated the task description. (Show Details)

• Gilles set Security to None.

Strangely I can't reproduce in Firefox. But I can in Chrome and Safari.

Works fine locally, could be bad data cached in beta (it's happened before). The investigation continues...

Yep, it's an issue where beta cached broken data about the commons repo:

http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=json&meta=filerepoinfo&smaxage=86400&maxage=86400

When opening this in Chrome, the articlePath key is missing. It's present in Firefox. Request the same URL without the maxage parameters in Chrome, and articlePath magically reappears.

Things should get back to normal once the broken data gets out of cache.

• Gilles edited a custom field.Mar 13 2015, 9:27 AM

Aklapper renamed this task from Download menu broken to Download menu broken (because beta cached broken data).Mar 13 2015, 9:37 AM