Page MenuHomePhabricator

QueryAllSpecialPagesTest for SpecialBrokenRedirects does not work on MySQL
Closed, DeclinedPublic


In resolving T37912, I noticed exactly one MediaWiki core unit test being skipped after the switchover that was not skipped beforehand.

00:17:54.368 22) QueryAllSpecialPagesTest::testQuerypageSqlQuery
00:17:54.368 SQL query for page BrokenRedirects can not be tested on MySQL backend (it reopens a temporary table)
00:17:54.369 /mnt/jenkins-workspace/workspace/mediawiki-phpunit-zend/src/tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php:60
00:17:54.369 /mnt/jenkins-workspace/workspace/mediawiki-phpunit-zend/src/tests/phpunit/MediaWikiTestCase.php:132


// With MySQL, skips special pages reopening a temporary table
// See
if (
	$wgDBtype === 'mysql'
	&& in_array( $page->getName(), $this->reopensTempTable )
) {
	$this->markTestSkipped( "SQL query for page {$page->getName()} "
		. "can not be tested on MySQL backend (it reopens a temporary table)" );

We should figure out a way to make this work on MySQL.

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle subscribed.
Krinkle edited projects, added MediaWiki-Special-pages; removed MediaWiki-libs-Rdbms.
Krinkle moved this task from To triage to Maintenance reports on the MediaWiki-Special-pages board.

Presumably fine now. Ignoring my old report for now.