Page MenuHomePhabricator

pywikibot breaks when it tries to report its own version when not run from a git checkout, breaking pwb completely
Closed, ResolvedPublic

Description

steps to reproduce:

↪ mktmpenv -p /usr/bin/python2
(tmp-12d9fdf76f20762)↪ cd -
~/dev/pywikibot-core
(tmp-12d9fdf76f20762)↪ python setup.py install
[...]
(tmp-12d9fdf76f20762)↪ git rev-parse HEAD
3320f7ca9916074af54432e4cc2548b0d362bddd
(tmp-12d9fdf76f20762)↪ python --version
Python 2.7.9
(tmp-12d9fdf76f20762)↪ cd /tmp
(tmp-12d9fdf76f20762)↪ python
Python 2.7.9 (default, Dec 11 2014, 04:42:00)
[GCC 4.9.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from pywikibot import bot

WARNING: Configuration variable 'google_key' is defined but unknown. Misspelled? >>> bot.handle_args() Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/wieland/dev/virtualenvs/tmp-12d9fdf76f20762/lib/python2.7/site-packages/pywikibot-2.0b3-py2.7.egg/pywikibot/bot.py", line 778, in handle_args init_handlers() File "/home/wieland/dev/virtualenvs/tmp-12d9fdf76f20762/lib/python2.7/site-packages/pywikibot-2.0b3-py2.7.egg/pywikibot/bot.py", line 291, in init_handlers writelogheader() File "/home/wieland/dev/virtualenvs/tmp-12d9fdf76f20762/lib/python2.7/site-packages/pywikibot-2.0b3-py2.7.egg/pywikibot/bot.py", line 318, in writelogheader version.getversion(online=config.log_pywiki_repo_version).strip()) File "/home/wieland/dev/virtualenvs/tmp-12d9fdf76f20762/lib/python2.7/site-packages/pywikibot-2.0b3-py2.7.egg/pywikibot/version.py", line 42, in getversion data = dict(getversiondict()) # copy dict to prevent changes in 'cache' File "/home/wieland/dev/virtualenvs/tmp-12d9fdf76f20762/lib/python2.7/site-packages/pywikibot-2.0b3-py2.7.egg/pywikibot/version.py", line 86, in getversiondict datestring = time.strftime('%Y/%m/%d, %H:%M:%S', date) TypeError: argument must be 9-item sequence, not datetime.datetime

Event Timeline

Mineo raised the priority of this task from to Unbreak Now!.
Mineo updated the task description. (Show Details)
Mineo added a project: Pywikibot.
Mineo subscribed.
Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptApr 7 2015, 5:05 PM

Change 202447 had a related patch set uploaded (by XZise):
[FIX] version: Use same time for the date and time

https://gerrit.wikimedia.org/r/202447

Change 202447 merged by jenkins-bot:
[FIX] version: Use same time for the date and time

https://gerrit.wikimedia.org/r/202447

@XZise: Patch merged. What exactly is left to do here? Should this still be highest priority? Or resolved?