Page MenuHomePhabricator
Create Task
Maniphest T95773

When editing post as wikitext, result is returned as wikitext, so can't be correctly re-rendered.
Closed, ResolvedPublic
Actions

Description

I used the wikitext editor to edit a post. The edit succeeds, but it doesn't return it in the right format, so it doesn't correctly re-render.

The request is

Wikitext_post_edit_returned_wrong.png (238×568 px, 20 KB)

It is returned as:

Wikitext_post_edit_returned_wrong_result.png (614×1 px, 56 KB)

You can see that it's returning wikitext (the same format as the input from the editor). It should be returned fixed HTML, since the edit is done, and we're now going to normal view mode.

The database/cache write itself is fine AFAICT, and a page reload will show everything normally again.

This is probably caused by the recent format refactoring, and is currently on Beta: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow .

Details

SubjectRepoBranchLines +/-
Stop requiring render data from POST APIsmediawiki/extensions/Flowmaster+84 -77
Stop submitHeader from needing submit-API outputmediawiki/extensions/Flowmaster+14 -10
Make lockTopic use _flowBoardComponentRefreshTopicmediawiki/extensions/Flowmaster+25 -72
Make newTopic use _flowBoardComponentRefreshTopicmediawiki/extensions/Flowmaster+7 -16
Make submitTopicTitle use _flowBoardComponentRefreshTopicmediawiki/extensions/Flowmaster+5 -26
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Apr 10 2015, 10:01 PM
• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, • DannyH, matthiasmullie, EBernhardson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2015, 10:01 PM
• Mattflaschen-WMF added projects: StructuredDiscussions, Collaboration-Team-Sprint-U-2015-04-22.Apr 10 2015, 10:02 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 10 2015, 10:02 PM
gerritbot subscribed.Apr 13 2015, 2:22 PM

Change 203819 had a related patch set uploaded (by Matthias Mullie):
Stop requiring render data from POST APIs

https://gerrit.wikimedia.org/r/203819

gerritbot added a project: Patch-For-Review.Apr 13 2015, 2:22 PM

Change 203820 had a related patch set uploaded (by Matthias Mullie):
Make submitTopicTitle use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203820

gerritbot added a comment.Apr 13 2015, 2:22 PM

Change 203821 had a related patch set uploaded (by Matthias Mullie):
Make newTopic use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203821

gerritbot added a comment.Apr 13 2015, 2:22 PM

Change 203822 had a related patch set uploaded (by Matthias Mullie):
Make lockTopic use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203822

gerritbot added a comment.Apr 13 2015, 2:22 PM

Change 203823 had a related patch set uploaded (by Matthias Mullie):
Stop submitHeader from needing submit-API output

https://gerrit.wikimedia.org/r/203823

matthiasmullie claimed this task.Apr 13 2015, 2:22 PM
matthiasmullie set Security to None.
matthiasmullie moved this task from Sprint U - ends April 22 to Needs Review on the Collaboration-Team-Sprint-U-2015-04-22 board.
matthiasmullie added a comment.Apr 13 2015, 5:50 PM

This was caused by changing 'contentFormat' param to 'format', because 'format' is also used for output format (or default to storage format)
Previously, those APIs didn't accept 'format' either, so we just returned default (usually storage format, I think)

Anyway, proper fix here IMO is to stop letting write APIs output render data: we (now) have read APIs that have all available info. That's what all above patches do.

EBernhardson moved this task from Needs Review to Code Review Started on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 13 2015, 10:24 PM
gerritbot added a comment.Apr 14 2015, 12:51 AM

Change 203819 merged by jenkins-bot:
Stop requiring render data from POST APIs

https://gerrit.wikimedia.org/r/203819

matthiasmullie mentioned this in rMEXTabfac702bf93: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 14 2015, 12:51 AM
EBernhardson mentioned this in rEFLW95e63552fbca: Stop requiring render data from POST APIs.Apr 14 2015, 12:51 AM
gerritbot added a comment.Apr 14 2015, 1:26 AM

Change 203820 merged by jenkins-bot:
Make submitTopicTitle use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203820

Diffusion mentioned this in rMEXTbe9141345ac4: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 14 2015, 1:26 AM
EBernhardson mentioned this in rEFLWcc649b777161: Make submitTopicTitle use _flowBoardComponentRefreshTopic.Apr 14 2015, 1:26 AM
gerritbot added a comment.Apr 14 2015, 7:08 PM

Change 203821 merged by jenkins-bot:
Make newTopic use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203821

EBernhardson mentioned this in rEFLWc4cabdec3273: Make newTopic use _flowBoardComponentRefreshTopic.Apr 14 2015, 7:08 PM
matthiasmullie mentioned this in rMEXTaa9ce07796c9: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 14 2015, 7:08 PM
gerritbot added a comment.Apr 15 2015, 4:23 PM

Change 203822 merged by jenkins-bot:
Make lockTopic use _flowBoardComponentRefreshTopic

https://gerrit.wikimedia.org/r/203822

matthiasmullie mentioned this in rEFLWc5813f4cf868: Make lockTopic use _flowBoardComponentRefreshTopic.Apr 15 2015, 4:23 PM
Diffusion mentioned this in rMEXTeb47f066e1c6: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 15 2015, 4:23 PM
gerritbot added a comment.Apr 15 2015, 4:51 PM

Change 203823 merged by jenkins-bot:
Stop submitHeader from needing submit-API output

https://gerrit.wikimedia.org/r/203823

EBernhardson mentioned this in rEFLW578bf0d585c5: Stop submitHeader from needing submit-API output.Apr 15 2015, 4:51 PM
Diffusion mentioned this in rMEXT6400e3c9fbd6: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 15 2015, 4:51 PM
EBernhardson moved this task from Code Review Started to Product Review on the Collaboration-Team-Sprint-U-2015-04-22 board.Apr 15 2015, 11:32 PM
• DannyH closed this task as Resolved.Apr 16 2015, 6:18 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-U-2015-04-22 board.
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 17 2015, 9:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits