Page MenuHomePhabricator

MobileFrontend makes UserLoginForm hook to pass incompatible parameter
Closed, ResolvedPublic

Description

MobileFrontend creates it's own Userlogin and UserCreate templates. These templates inherits QuickTemplate while core templates inherits BaseTemplate. If another extension (which is included _after_ MobileFrontend in LocalSettings.php) requires functions from BaseTemplate in it's UserLoginFrom or UserCreateForm hook handler (which is legitim, because UserCreateTemplate is the expected class), php ends with a fatal error. MobileFrontend should also inherit BaseTemplate instead of QuickTemplate to prevent these problems.

Encountered with installed MobileFrontend and GoogleLogin extension.

Event Timeline

Florian created this task.Apr 11 2015, 9:39 PM
Florian claimed this task.
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: MobileFrontend.
Florian added a subscriber: Florian.
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptApr 11 2015, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 203622 had a related patch set uploaded (by Florianschmidtwelzow):
Use BaseTemplate instead of QuickTemplate to create UserLoginAndCreateTemplate

https://gerrit.wikimedia.org/r/203622

Change 203622 merged by jenkins-bot:
Use BaseTemplate instead of QuickTemplate to create UserLoginAndCreateTemplate

https://gerrit.wikimedia.org/r/203622

Florian closed this task as Resolved.Apr 13 2015, 6:04 PM
Florian added a project: GoogleLogin.
Florian removed a project: Patch-For-Review.
Florian set Security to None.