Maniphest T96672

BotEditTest fails because of a core update
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	thiemowmde
	Apr 21 2015, 12:16 PM

Tags

Referenced Files

None

Subscribers

Description

Currently a test constantly fails on Jenkins. I can reproduce it with an updated core:

1) Wikibase\Test\Api\BotEditTest::testBotEdits with data set #1 (array('Empty', 'wbsetlabel', 'en', 'ALabel2'), array(false))
Must not have a 'bot' key in the rc-entry of the result from the API
Failed asserting that false is true.

/var/www/mediawiki/core/extensions/Wikibase/repo/tests/phpunit/includes/api/BotEditTest.php:156
/var/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:131

https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-mysql-hhvm/458/console

Details

	Subject	Repo	Branch	Lines +/-
	Fix broken BotEditTest	mediawiki/extensions/Wikibase	master	+10 -6

Customize query in gerrit

Event Timeline

thiemowmde created this task.Apr 21 2015, 12:16 PM

thiemowmde raised the priority of this task from to Unbreak Now!.

thiemowmde updated the task description. (Show Details)

thiemowmde added projects: Wikidata, Wikidata-Sprint-2015-04-21.

thiemowmde added subscribers: thiemowmde, JanZerebecki.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2015, 12:16 PM

Change 205586 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix broken BotEditTest

https://gerrit.wikimedia.org/r/205586

gerritbot added a project: Patch-For-Review.Apr 21 2015, 12:34 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-04-21 board.Apr 21 2015, 12:53 PM

Change 205586 abandoned by Thiemo Mättig (WMDE):
Fix broken BotEditTest

Reason:
Please review If0c0fe2 instead.

https://gerrit.wikimedia.org/r/205586

Merged https://gerrit.wikimedia.org/r/#/c/205572/ .

aude closed this task as Resolved.Apr 21 2015, 2:05 PM

aude removed a project: Patch-For-Review.

aude set Security to None.

Tobi_WMDE_SW moved this task from Review to Done on the Wikidata-Sprint-2015-04-21 board.Apr 21 2015, 3:39 PM