Page MenuHomePhabricator

Investigate Vary:Accept-Encoding issues on cache clusters
Closed, InvalidPublic

Description

It seems we could be hurting on cache efficiency due to MW commonly sending Vary:Accept-Encoding and us not sanitizing the client's Accept-Encoding per the example in https://www.varnish-cache.org/docs/3.0/tutorial/vary.html . On a quick check of varnish logs, I see examples of both MW backend sending that Vary header, and of various clients sending us all kinds of variations (e.g. "gzip, deflate" vs "gzip,deflate" vs "gzip, deflate, sdch" (chrome))...

Event Timeline

BBlack raised the priority of this task from to High.
BBlack updated the task description. (Show Details)
BBlack added projects: acl*sre-team, Traffic.
BBlack subscribed.

Change 206387 had a related patch set uploaded (by BBlack):
sanitize Accept-Encoding for cache efficiency T97128

https://gerrit.wikimedia.org/r/206387

I want to read and investigate a little further first, and also test this in isolated places before cluster-wide, but the patch above is the general idea...

BBlack claimed this task.

Varnish already handles this sanely, I was just reading the wrong outdated documentation apparently!