Page MenuHomePhabricator

External Editor not used when editing sections
Closed, DeclinedPublic

Description

Author: stuart

Description:
In Internet Explorer, if you click the "Edit this page" link on a page on Wikipedia, you will be
prompted with a dialog box for index.php rather than actually seeing the page. This occurs in IE7 and
IE6. This does not occur on the versions of MediaWiki used for BYOBpedia and developer.valvesoftware.com


Version: unspecified
Severity: minor
URL: http://en.wikipedia.org/w/index.php?title=Hydrogen&action=edit

Details

Reference
bz7744

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:24 PM
bzimport set Reference to bz7744.
bzimport added a subscriber: Unknown Object (MLST).

jeluf wrote:

please provide a URL where this behaviour can be observed.

stuart wrote:

Note that you have to be logged in for it to not work.

lcarsdata wrote:

Check in your preferences, you have probably checked the "Use external editor by
default" boxes (under the edit tab). Uncheck them then make sure you have purge
your cache (Ctrl+F5 in IE6).

stuart wrote:

Well then I guess there's still a bug in the implementation: if you edit a section via right-click, it doesn't open
the external editor.

Issue revised.

I don't understand what you're saying here. Please clarify.

robchur wrote:

Andrew,

  • Users can configure a specific MIME type to open a control file in an

application or script which then handles external editing of the page for them

  • MediaWiki can deliver this control file if users request it in their preferences
  • Users can also select a preference option which causes them to be able to

right-click on section headings to open section editing mode

Apparently, the two are not working, i.e. users who have opted to open edits in
an external editor are unable to do this when using the section editing shortcut.

I can't see how this can be *simplified* further. :) However, comments 1 and 3
seem to conflict.

Okay, I understand. I wasn't sure what the "right-click" he was talking about
was. I might have a poke in the code to see what I can dig up. Thanks, Rob.

stuart wrote:

The first few comments were from when I was confused as to how I had the external option checked. I changed it with
Comment #4 to this.

Looks like the "use external editor" option doesn't work at all with section editing, even without the JS option, changing the summary.

We killed the external editor in Ic3791d18.