Page MenuHomePhabricator
Create Task
Maniphest T99346

Internal links in <noinclude> are not displayed correctly in revision history
Closed, ResolvedPublic
Actions

Description

on https://www.wikidata.org/w/index.php?title=Wikidata:Requests_for_permissions/Bot/MineoBot_8&action=history the only entry at the moment is

(Created page with "<noinclude>3}}</noinclude> === User:MineoBot 8=== {{Request for permissions/links|Mineo...")

where "3}}" is a link to https://www.wikidata.org/wiki/Category:Requests_for_permissions/Bot. The wikitext of that part is actually "<noinclude>[[Category:Requests for permissions/Bot|MineoBot 8]]</noinclude>", so I'm not even sure where "3}}" is coming from.

I have no idea which of the gazillion projects is the right one for this.

Details

SubjectRepoBranchLines +/-
Handle links with multiple pipes correctly in edit summariesmediawiki/coremaster+24 -4
Customize query in gerrit

Related Objects

Event Timeline

Mineo created this task.May 16 2015, 9:31 AM
Mineo raised the priority of this task from to Needs Triage.
Mineo updated the task description. (Show Details)
Mineo subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2015, 9:31 AM
TTO added projects: MediaWiki-Page-diffs, MediaWiki-Parser.May 16 2015, 9:57 AM
TTO subscribed.

If not sure, use General/Unknown. Let's try these ones though

TTO triaged this task as Low priority.May 16 2015, 10:00 AM

According to the API, the actual wikitext source for the edit summary is

Created page with "<noinclude>[[Category:Requests for permissions/Bot|{{subst:#titleparts:{{subst:PAGENAME}}|1|3}}]]</noinclude> === [[User:MineoBot|]] 8=== {{Request for permissions/links|Mineo..."

Apparently the mini-parser used to interpret edit summaries has trouble with the multiple pipes, and discards a bunch of text.

Quiddity added a parent task: T119681: [DO NOT USE] Edit summary issues (tracking) [superseded by #MediaWiki-Commenting].Nov 26 2015, 12:38 AM
gerritbot subscribed.Nov 29 2015, 10:30 AM

Change 255919 had a related patch set uploaded (by TTO):
Handle links with multiple pipes correctly in edit summaries

https://gerrit.wikimedia.org/r/255919

gerritbot added a project: Patch-For-Review.Nov 29 2015, 10:30 AM
TTO claimed this task.Feb 20 2016, 2:01 AM
gerritbot added a comment.Sep 23 2016, 8:19 AM

Change 255919 merged by jenkins-bot:
Handle links with multiple pipes correctly in edit summaries

https://gerrit.wikimedia.org/r/255919

TTO closed this task as Resolved.Sep 23 2016, 8:58 AM

Should be fixed. Please check this edit summary on-wiki next week; it should display properly.

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 23 2016, 9:00 AM
TTO added a comment.Dec 21 2016, 1:48 PM

Now displays correctly, or at least, more correctly than before:

(Created page with "<noinclude>{{subst:#titleparts:{{subst:PAGENAME}}|1|3}}</noinclude> === User:MineoBot 8=== {{Request for permissions/links|Mineo...")
                               --------------------------------------------                 -------------

where --- represents links.

TTO mentioned this in T61124: Invalid parameter for message "parentheses".Feb 4 2017, 2:57 AM
MGChecker added a project: MediaWiki-Comment-store.Nov 12 2018, 7:08 PM
MGChecker removed a parent task: T119681: [DO NOT USE] Edit summary issues (tracking) [superseded by #MediaWiki-Commenting].Nov 12 2018, 7:10 PM
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptSep 20 2019, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL