| AzaToth | |
| Nov 17 2006, 11:04 PM |
| F3257: throw1.patch | |
| Nov 21 2014, 9:25 PM |
The current tactic to set the return value to false to indicate that something
went wrong is (at least in my opinion) a "Bad thing", following patch implements
better (IMO) Exception handling.
As I'm lazy, this patch will depend on bug 6068, as I'm to lazy to remove those
from the patch.
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T8068 Change behaviour of MOD and DIV operators | |||
| Resolved | None | T9964 Better errorhandling in ExprParser |
the patch
removed the parts that is designated to the other bug
attachment throw1.patch ignored as obsolete
the patch
made the changes brion pointed out.
attachment throw1.patch ignored as obsolete
the patch
forgot to fix the space -> tab problem in ParserFunctions.php also (had some
strangle rules in .vimrc that was hidden in the bottom)
attachment throw1.patch ignored as obsolete
robchur wrote:
Don't post patches that depend upon each other, it makes reviewing code changes
harder. You've been advised about this before. Thanks.
(In reply to comment #7)
Don't post patches that depend upon each other, it makes reviewing code changes
harder. You've been advised about this before. Thanks.
I was told by brion to do so, so please don't complain.
robchur wrote:
Of course, the correct response to that would have been a quick email, "Hey
dude, Brion asked me to...blah blah blah".
(In reply to comment #9)
Of course, the correct response to that would have been a quick email, "Hey
dude, Brion asked me to...blah blah blah".
Oh, I'm sorry, I'll think about that next time.